Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SecretRoomsMod #32

Closed
EnderMelody opened this issue Mar 13, 2021 · 5 comments
Closed

Add support for SecretRoomsMod #32

EnderMelody opened this issue Mar 13, 2021 · 5 comments

Comments

@EnderMelody
Copy link

  • Minecraft Version: 1.16.5
  • Mod Version: 1.16.4-2.5.1
    Currently, hidden blocks such as the 'Torch lever' are displayed as their real name.
    2021-03-13_11 24 39
    They should instead be using the block the are mimicking's name instead.
@embeddedt
Copy link

Secret Rooms for 1.16+ didn't have plugins to show the fake block's information. I implemented this upstream, it's just waiting on a release: Wyn-Price/SecretRooms#71

I don't think it's an issue with any particular Hwyla implementation, so this can probably be closed now?

@Snownee
Copy link
Owner

Snownee commented Feb 25, 2022

@embeddedt no, the API you are using is added by WTHIT. there is even no IBlockComponentProvider in Hwyla

@Snownee
Copy link
Owner

Snownee commented Feb 25, 2022

I will just address this issue to Snownee/JadeAddons#2

@Snownee Snownee closed this as completed Feb 25, 2022
@Snownee
Copy link
Owner

Snownee commented Feb 25, 2022

@embeddedt and one more thing: I don't think your PR will work for the Torch Lever

@embeddedt
Copy link

Hmm.. it's my understanding that WTHIT renamed the original interface from Hwyla, making it impossible to support both mods simultaneously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants