node.js version check doesn't work

[alexanderdean]

TASK: [nodejs | Node.js | Checking installed version of node.js] **************
failed: [127.0.0.1] => {"changed": true, "cmd": "/usr/bin/test "$(node -v 2> /dev/null)" = v0.10.25 ", "delta": "0:00:00.003899", "end": "2014-03-17 11:08:12.214885", "item": "", "rc": 1, "start": "2014-03-17 11:08:12.210986"}
...ignoring

[alexanderdean]

One for Fred

[fblundun]

I thought this was intentional - the idea being that if the check fails then node is fetched and installed?

[alexanderdean]

The task literally fails - meaning crash not non-zero result code. There's something non-robust in the check syntax, it needs playing around with on the command-line

[fblundun]

It looks like tasks are reported as failed whenever the result code is non-zero - for example,

shell: /bin/false

So I've added a failed_when command so that the task is only reported as failed if the result code is > 1.

[alexanderdean]

Nice, thanks Fred...