Prevent duplicates in web vital measurements (Close #215) #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowplowcla
added
the
cla:yes
agnessnowplow
force-pushed
the
fix/cwv_dupes
branch
from
f7b00c6
to
7694fe9
Compare
|
Why only Snowflake and RS/PG? Also, would it be a lot of work to add a test record for this to to the int tests? |
agnessnowplow
force-pushed
the
fix/cwv_dupes
branch
from
7694fe9
to
d8a9710
Compare
|
As agreed I created an issue to rewamp the int tests and tested the results for Snowflake locally, which eliminated the duplicate issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
This is to fix potential dupes in case there is any null value for grouping sets. Redshift tested locally.
#215
Checklist