-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/r9 #339
Merged
Merged
Release/r9 #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguzhanunlu
force-pushed
the
release/r9
branch
12 times, most recently
from
February 21, 2018 16:34
4e2ef38
to
2fad134
Compare
oguzhanunlu
force-pushed
the
release/r9
branch
9 times, most recently
from
March 1, 2018 14:52
6ccb342
to
1f9915c
Compare
oguzhanunlu
force-pushed
the
release/r9
branch
6 times, most recently
from
March 8, 2018 00:27
46db3af
to
b019f38
Compare
oguzhanunlu
force-pushed
the
release/r9
branch
6 times, most recently
from
April 16, 2018 14:04
9505c0e
to
fc12520
Compare
oguzhanunlu
force-pushed
the
release/r9
branch
2 times, most recently
from
April 18, 2018 12:32
cbd4b04
to
230ae5c
Compare
chuwy
approved these changes
Apr 18, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hey @alexanderdean, I've done with QA and review. Green light from me! @oguzhanunlu, please squash temporary commits. |
Great work both! Please:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
------ RELEASE TO-DO BELOW ----------