Skip to content

Commit

Permalink
Update vendor and version of the player schema used in the media plug…
Browse files Browse the repository at this point in the history
…in (close #1222)

PR #1223
  • Loading branch information
matus-tomlein authored and greg-el committed Aug 10, 2023
1 parent c754d52 commit f1bd82a
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@snowplow/browser-plugin-media",
"comment": "Update version of the player schema used in the media plugin to 2-0-0 (#1222)",
"type": "none"
}
],
"packageName": "@snowplow/browser-plugin-media"
}
3 changes: 2 additions & 1 deletion plugins/browser-plugin-media/src/schemata.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ import { MediaEventType } from './types';

const MEDIA_SCHEMA_PREFIX = 'iglu:com.snowplowanalytics.snowplow.media/';
const MEDIA_SCHEMA_SUFFIX = '/jsonschema/1-0-0';
export const MEDIA_PLAYER_SCHEMA = MEDIA_SCHEMA_PREFIX + 'player' + MEDIA_SCHEMA_SUFFIX;
// NOTE: The player schema has a different vendor than the other media schemas because it builds on an older version of the same schema. Versions 3.12 to 3.13.1 of the media plugin used a conflicting schema URI which has since been removed from Iglu Central.
export const MEDIA_PLAYER_SCHEMA = 'iglu:com.snowplowanalytics.snowplow/media_player/jsonschema/2-0-0';
export const MEDIA_SESSION_SCHEMA = MEDIA_SCHEMA_PREFIX + 'session' + MEDIA_SCHEMA_SUFFIX;
export const MEDIA_AD_SCHEMA = MEDIA_SCHEMA_PREFIX + 'ad' + MEDIA_SCHEMA_SUFFIX;
export const MEDIA_AD_BREAK_SCHEMA = MEDIA_SCHEMA_PREFIX + 'ad_break' + MEDIA_SCHEMA_SUFFIX;
Expand Down
2 changes: 1 addition & 1 deletion trackers/javascript-tracker/test/integration/vimeo.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const makeContext = () => {
schema: 'iglu:com.snowplowanalytics.snowplow/contexts/jsonschema/1-0-0',
data: [
{
schema: 'iglu:com.snowplowanalytics.snowplow.media/player/jsonschema/1-0-0',
schema: 'iglu:com.snowplowanalytics.snowplow/media_player/jsonschema/2-0-0',
data: {
currentTime: jasmine.any(Number),
paused: jasmine.any(Boolean),
Expand Down

0 comments on commit f1bd82a

Please sign in to comment.