Update vendor and version of the player schema used in the media plugin (close #1222) #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonFiles added (6)
Total files change +95.15KB 0% Final result: ✅ View report in BundleMon website ➡️ |
igneel64
approved these changes
Aug 8, 2023
igneel64
reviewed
Aug 8, 2023
| @@ -2,7 +2,7 @@ import { MediaEventType } from './types'; | |||
|
|
|||
| const MEDIA_SCHEMA_PREFIX = 'iglu:com.snowplowanalytics.snowplow.media/'; | |||
| const MEDIA_SCHEMA_SUFFIX = '/jsonschema/1-0-0'; | |||
| export const MEDIA_PLAYER_SCHEMA = MEDIA_SCHEMA_PREFIX + 'player' + MEDIA_SCHEMA_SUFFIX; | |||
| export const MEDIA_PLAYER_SCHEMA = 'iglu:com.snowplowanalytics.snowplow/media_player/jsonschema/2-0-0'; | |||
There was a problem hiding this comment.
We might want to leave a comment thought, WDYT ?
There was a problem hiding this comment.
Good thinking, have added a comment!
matus-tomlein
changed the title
matus-tomlein
added a commit
that referenced
this pull request
Aug 9, 2023
greg-el
pushed a commit
that referenced
this pull request
Aug 10, 2023
greg-el
pushed a commit
that referenced
this pull request
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1222
This PR updates the schema for the player entity used in the media plugin.
The previous schema had a conflict with another one which could lead to problems when loading data to warehouses. To face this, we republished the schema under the URI
iglu:com.snowplowanalytics.snowplow/media_player/jsonschema/2-0-0.