Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to read Thrift SnowplowRawEvent to common-enrich #462

Closed
alexanderdean opened this issue Jan 6, 2014 · 11 comments
Closed

Add ability to read Thrift SnowplowRawEvent to common-enrich #462

alexanderdean opened this issue Jan 6, 2014 · 11 comments
Assignees
Milestone

Comments

@alexanderdean
Copy link
Member

Assigning to Brandon but I'm (@alexanderdean) very happy to help!

@alexanderdean
Copy link
Member Author

Depends on #475

@bamos
Copy link
Contributor

bamos commented Jan 8, 2014

Hi @alexanderdean - should we rename one of com.snowplowanalytics.snowplow.collectors.thrift.TrackerPayload and com.snowplowanalytics.snowplow.enrich.common.inputs.TrackerPayload?

@alexanderdean
Copy link
Member Author

Hmm, good point. Of the two of these, thrift.TrackerPayload is the more permanent, so I guess we can import inputs.TrackerPayload => ITP or similar?

@bamos
Copy link
Contributor

bamos commented Jan 8, 2014

Okay, I'll do that

@bamos
Copy link
Contributor

bamos commented Jan 8, 2014

Hm, with renaming, I get importedTrackerPayload' is permanently hidden by definition of object TrackerPayload in package inputs, so I'm doing thrift.TrackerPayload => ThriftTrackerPayload.

bamos pushed a commit that referenced this issue Jan 8, 2014
@alexanderdean
Copy link
Member Author

thrift.TrackerPayload => ThriftTrackerPayload sounds good to me...

@bamos
Copy link
Contributor

bamos commented Jan 8, 2014

Hi @alexanderdean - just taking a shot here. Can you make a pass when you get a chance?

@alexanderdean
Copy link
Member Author

For sure - will do!

@alexanderdean
Copy link
Member Author

Assigning to Alex to review.

In the meantime, have published current as a snapshot:

info] Main Scala API documentation successful.
[info] Packaging /vagrant/snowplow/3-enrich/scala-common-enrich/target/snowplow-common-enrich-0.2.0-SNAPSHOT-javadoc.jar ...
[info] Done packaging.
[info]  published snowplow-common-enrich to /var/www/maven.snplow.com/prod/public/snapshots/com/snowplowanalytics/snowplow-common-enrich/0.2.0-SNAPSHOT/snowplow-common-enrich-0.2.0-SNAPSHOT.pom
[info]  published snowplow-common-enrich to /var/www/maven.snplow.com/prod/public/snapshots/com/snowplowanalytics/snowplow-common-enrich/0.2.0-SNAPSHOT/snowplow-common-enrich-0.2.0-SNAPSHOT.jar
[info]  published snowplow-common-enrich to /var/www/maven.snplow.com/prod/public/snapshots/com/snowplowanalytics/snowplow-common-enrich/0.2.0-SNAPSHOT/snowplow-common-enrich-0.2.0-SNAPSHOT-sources.jar
[info]  published snowplow-common-enrich to /var/www/maven.snplow.com/prod/public/snapshots/com/snowplowanalytics/snowplow-common-enrich/0.2.0-SNAPSHOT/snowplow-common-enrich-0.2.0-SNAPSHOT-javadoc.jar
[success] Total time: 26 s, completed Jan 9, 2014 4:42:26 PM

@bamos
Copy link
Contributor

bamos commented Jan 9, 2014

Awesome, thanks @alexanderdean!

bamos pushed a commit that referenced this issue Jan 10, 2014
@alexanderdean
Copy link
Member Author

This is looking great. I will add a few more tests when I get a chance but let's treat this ticket as complete now.

oguzhanunlu pushed a commit to snowplow/common-enrich that referenced this issue May 29, 2020
oguzhanunlu pushed a commit to snowplow/common-enrich that referenced this issue May 29, 2020
oguzhanunlu pushed a commit to snowplow/common-enrich that referenced this issue May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants