Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SQL file reading to startup #22

Closed
alexanderdean opened this issue Mar 11, 2015 · 1 comment
Closed

Move SQL file reading to startup #22

alexanderdean opened this issue Mar 11, 2015 · 1 comment
Assignees
@jbeemster
Labels
enhancement
Milestone
Version 0.4.0

Comments

@alexanderdean
Copy link
Member

At the moment, SQL files are read "just-in-time" - i.e. when they are needed to run a query.

We should move to "eager" reading of SQL files on startup. That way, if any of the SQL files are missing, we will know at startup. Also, it protects us from e.g. deployment updates to the SQL files during execution of a playbook.

/cc @yalisassoon
@alexanderdean alexanderdean self-assigned this Mar 11, 2015
@alexanderdean alexanderdean added this to the Version 0.2.0 milestone Mar 11, 2015
@alexanderdean alexanderdean mentioned this issue Nov 16, 2015
Closed
@alexanderdean
Copy link
Member Author

@jbeemster - would it be possible to bring this forwards into 0.4.0? It is starting to cause pain with deployments (basically clients redeploying their SQLs during a run breaks things)...

jbeemster added a commit that referenced this issue Nov 23, 2015
@jbeemster
Move SQL file reading to startup (closes #22)
2996c9c
jbeemster added a commit that referenced this issue Nov 24, 2015
@jbeemster
Move SQL file reading to startup (closes #22)
e624b3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbeemster jbeemster

Labels
enhancement
Projects
None yet
Milestone
Version 0.4.0
Development

No branches or pull requests
2 participants
@alexanderdean @jbeemster