Add sourceProcessWithStreams #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to snoyberg#250
| , (sourceStderr, closeStderr) | ||
| , cph) <- streamingProcess cp | ||
| (_, resStdout, resStderr) <- | ||
| runConcurrently $ (,,) |
There was a problem hiding this comment.
Question: what behavior do we want if the provided Source or Sinks throw an exception? It may be appropriate to have an onException here that closes the streams and kills the child process. Thoughts?
There was a problem hiding this comment.
That thought occurred to me when I saw your recent addition of withCheckedProcessCleanup.
I think it's reasonable to do that. I suppose if a user doesn't want the subprocess killed then they can catch exceptions in the Source/Sinks.
Should that also be added to sourceProcessWithConsumer? I'll assume so for now and add it to the PR.
sourceProcessWithConsumer and sourceProcessWithStreams now terminates the process if their streams raises an exception
|
@snoyberg I've added the suggested exception handling. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #250