This repository has been archived by the owner on Apr 4, 2022. It is now read-only.
Rewrite the dump library to avoid intermediate heap allocations #52
Labels
inefficiency
The results are correct, but less efficient than they should be.
The YAML output code used by pstore-dump was originally written for another project. That project in general dealt with very small files of the order of a few kilobytes at most. For this reason, the code prioritised the appearance of its output over output performance.
Reusing the code in pstore-dump was expedient: it got the tool up-and-running very quickly.
However, pstore files can hold many megabytes of data meaning that the performance of the tool can be important. Currently, any command that produces a lot of output can take a long time.
For this reason, I proposed that we eliminate the intermediate objects and dump the output directly.
The text was updated successfully, but these errors were encountered: