Fix UBSAN reported access within misaligned addresses #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be target toward |
sergio-nsk
force-pushed
the
sergey/ubsan/1
branch
3 times, most recently
from
5e33775
to
299e092
Compare
Merge to |
nmoinvaz
approved these changes
Aug 7, 2024
sergio-nsk
changed the title
sergio-nsk
force-pushed
the
sergey/ubsan/1
branch
from
299e092
to
6490ac4
Compare
This is can be an issue on ARM, it can cause a hang of CrashReportTest.MiniDump test on macOS.
It passed null pointer as a second argument to std::memcpy() when crash_exception_info was empty. This exhibited the undefined behavior.
sergio-nsk
force-pushed
the
sergey/ubsan/1
branch
from
6490ac4
to
9de80df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is can be an issue on ARM, it can cause a hang of
CrashReportTest.MiniDumptest on macOS, that I quite often observe.I will propose these changes to Chromium.