Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test release artifacts individually #2599

Closed
wants to merge 4 commits into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Jan 18, 2022

WIP

In order to test the actual artifacts we release, this PR splits the "Dev Release" job in CI into multiple build jobs, one for each artifact. Each artifact is then tested against our acceptance tests.

As Dev Release mirrors Prod Release, this change will also apply to Prod Release. An additional step will combine each artifact and publish them as we currently do. This means all artifacts must pass their tests before a release is made.

To avoid needing to write a script which conditional builds specific artifacts (a lot of tedious logic and build orchestration), I'll first attempt to migrate our workflows from ad-hoc scripts and npm to Makefile(s) which can orchestrate for us.

Follow up to #2495

@ghost ghost changed the title chore: migrate from npm scripts to makefile chore: test release artifacts individually Jan 18, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 18, 2022

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • src/lib/analytics/getStandardData.ts
Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against ef2ec8f

@ghost ghost force-pushed the chore/split-build branch 28 times, most recently from 992dbe7 to 54850bb Compare January 19, 2022 18:30
@ghost ghost force-pushed the chore/split-build branch 2 times, most recently from 66b2c27 to 3745c5a Compare January 31, 2022 19:25
@ghost ghost closed this May 23, 2022
@darscan darscan deleted the chore/split-build branch January 20, 2023 18:05
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
0 participants