Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spike: add linux/arm64 binary builds #2495

Closed
wants to merge 1 commit into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Dec 21, 2021

Requires:

To Do

  • Add linux/arm64 pkg builds
  • Add arm64 test pipeline

Follow up to:

Probable Hurdles

  • This is the first time we're building against different architectures. Things will likely break.
  • arm64 isn't very popular so things will likely not work in weird ways.
  • We may need clean builds for different platform/architectures as some deps probably compile things accordingly.

Errors

https://app.circleci.com/pipelines/github/snyk/snyk/8735/workflows/e772108d-8eb2-4605-8e36-0a372748aabc/jobs/66274

5283 timing reify:rollback:retireShallow Completed in 0ms
5284 timing command:ci Completed in 33449ms
5285 verbose type version
5286 verbose stack chalk: No matching version found for chalk@4.1.1.
5286 verbose stack     at module.exports (/opt/circleci/.nvm/versions/node/v16.13.0/lib/node_modules/npm/node_modules/npm-pick-manifest/index.js:209:23)
5286 verbose stack     at /opt/circleci/.nvm/versions/node/v16.13.0/lib/node_modules/npm/node_modules/pacote/lib/registry.js:118:26
5286 verbose stack     at async Arborist.[extractOrLink] (/opt/circleci/.nvm/versions/node/v16.13.0/lib/node_modules/npm/node
_modules/@npmcli/arborist/lib/arborist/reify.js:672:7)
5286 verbose stack     at async /opt/circleci/.nvm/versions/node/v16.13.0/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/reify.js:602:9
5287 verbose cwd /home/circleci/snyk
5288 verbose Linux 5.4.0-1035-aws
5289 verbose argv "/opt/circleci/.nvm/versions/node/v16.13.0/bin/node" "/opt/circleci/.nvm/versions/node/v16.13.0/bin/npm" "ci"
5290 verbose node v16.13.0
5291 verbose npm  v8.1.0
5292 error code ETARGET
5293 error notarget No matching version found for chalk@4.1.1.
5294 error notarget In most cases you or one of your dependencies are requesting
5294 error notarget a package version that doesn't exist.
5295 verbose exit 1

Looks like prefer-offline doesn't work on arm64. Removing the following fixed it:

npm config set prefer-offline true

@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2021

Fails
🚫

Commit "wip: arm64 test pipeline" is not a valid commitizen message. See Contributing page with required commit message format.

Messages
📖

This PR will not trigger a new version. It doesn't include any commit message with feat or fix.

Generated by 🚫 dangerJS against 38bbb71

@ghost ghost changed the title wip: linux arm64 feat: add linux/arm64 binary builds Dec 21, 2021
@ghost ghost force-pushed the feat/linux-arm64 branch 15 times, most recently from dd87239 to 2100561 Compare December 23, 2021 19:56
@JackuB JackuB mentioned this pull request Jan 13, 2022
@ghost ghost changed the title feat: add linux/arm64 binary builds spike: add linux/arm64 binary builds Feb 7, 2022
@ghost
Copy link
Author

ghost commented Feb 7, 2022

Follow up: #2732

@ghost ghost closed this Feb 7, 2022
@JackuB JackuB deleted the feat/linux-arm64 branch March 15, 2022 12:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
0 participants