feat: add error handling for limit errors #210
Conversation
nick-watson
force-pushed
the
feat/handle-limit-catalogue-errors
branch
from
73ed509
to
a95f1ef
Compare
nick-watson
changed the title
nick-watson
force-pushed
the
feat/handle-limit-catalogue-errors
branch
2 times, most recently
from
6d79ba4
to
569d212
Compare
nick-watson
force-pushed
the
feat/handle-limit-catalogue-errors
branch
from
569d212
to
89ee52f
Compare
| const errors = response?.body?.errors; | ||
|
|
||
| if (isJsonApiErrors(errors)) { | ||
| jsonApiError = errors[0]; |
There was a problem hiding this comment.
nit: This behaviour (only handling first error) is not documented anywhere.
I don't see cases where we have more than one error from the API TBH, but know the JSON API requires arrays.
If someone were to change the API to actually return more than one error they will probably not realise the client can only handle one though.
There was a problem hiding this comment.
Yeah I guess this is a limitation right now, where would you think we can document it?
There was a problem hiding this comment.
The good thing is if we have more than 1 error, nothing breaks. They will be ignored.
Perhaps a single comment from the service that throws the error?
|
🎉 This PR is included in version 4.23.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What does this PR do?
Screenshots