Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CliDownloader#getLatestVersion() does not close streams #2

Closed
bmuschko opened this issue Aug 5, 2021 · 2 comments
Closed

CliDownloader#getLatestVersion() does not close streams #2

bmuschko opened this issue Aug 5, 2021 · 2 comments
Assignees
@bmvermeer
Labels
enhancement New feature or request

Comments

@bmuschko
Copy link

bmuschko commented Aug 5, 2021 •
edited
Loading

This method creates streams but doesn't close them in a finally block. Therefore, those stream stay around for longer than needed.

The same behavior can be observed in the class Runner.
@bmvermeer
Copy link
Collaborator

Technically yes, however in practice the lifetime of the complete runtime is short.
I consider this a minor issue

@bmvermeer bmvermeer added the enhancement New feature or request label Aug 5, 2021
@bmuschko
Copy link
Author

bmuschko commented Aug 5, 2021

Not if you run the Gradle build with the daemon option which is the default. For that reason, you have a potential resource leak.

@bmvermeer bmvermeer mentioned this issue Aug 5, 2021
Merged
@bmvermeer bmvermeer self-assigned this Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmvermeer bmvermeer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bmuschko @bmvermeer