Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CliDownloader#downloadLatestVersion() uses internal Gradle classes #3

Closed
bmuschko opened this issue Aug 5, 2021 · 2 comments
Closed

CliDownloader#downloadLatestVersion() uses internal Gradle classes #3

bmuschko opened this issue Aug 5, 2021 · 2 comments
Assignees
@bmvermeer
Labels
enhancement New feature or request

Comments

@bmuschko
Copy link

bmuschko commented Aug 5, 2021 •
edited
Loading

While convenient, internal Gradle classes should never be used as they can introduce breaking changes with a new Gradle runtime version and therefore may break the consumer of this plugin. Example: https://github.com/snyk/gradle-plugin/blob/master/src/main/java/io/snyk/gradle/plugin/CliDownloader.java#L66

The same behavior can be observed in SnykBinaryTask.
@bmvermeer
Copy link
Collaborator

Great suggestion

@bmvermeer bmvermeer added the enhancement New feature or request label Aug 5, 2021
@bmuschko bmuschko changed the title CliDownloader#downloadLatestVersion uses internal Gradle classes CliDownloader#downloadLatestVersion() uses internal Gradle classes Aug 5, 2021
@bmvermeer bmvermeer self-assigned this Aug 6, 2021
@bmvermeer bmvermeer mentioned this issue Aug 6, 2021
Merged
@trevjonez
Copy link

Seems this should be closed. Neither of the classes in the OP are using anything but public gradle API now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmvermeer bmvermeer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bmuschko @trevjonez @bmvermeer