Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tomtom fails without altid #37

Closed
snystrom opened this issue May 15, 2020 · 1 comment
Closed

tomtom fails without altid #37

snystrom opened this issue May 15, 2020 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@snystrom
Copy link
Owner

snystrom commented May 15, 2020

Issues
Main reason for this feature is to avoid rare scenario where two motifs may have identical names (like if the user joined two data.frames).

Possible Solutions

  • It may be that tomtom doesn't allow identical named motifs as input (haven't checked this). If this is the case, then I can drop requirement of altname and instead check & error if names are non-unique?
  • add altname columns to everything initialized with NA_character_ if altname column does not exist.
@snystrom snystrom mentioned this issue May 28, 2020
47 tasks
@snystrom snystrom added the bug Something isn't working label Jun 24, 2020
@snystrom snystrom added this to the Release 1.0 milestone Jun 29, 2020
@snystrom
Copy link
Owner Author

snystrom commented Jul 1, 2020

Test whether importTomTomXML has same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant