Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reconsider our use of --no-permission-warning because sometimes it is hiding actual permission problems #811

Closed
joshrabinowitz opened this issue Mar 31, 2022 · 0 comments · Fixed by #812
Closed

reconsider our use of --no-permission-warning because sometimes it is hiding actual permission problems #811

joshrabinowitz opened this issue Mar 31, 2022 · 0 comments · Fixed by #812

Comments

@joshrabinowitz
Copy link
Collaborator

joshrabinowitz commented Mar 31, 2022 •
edited

many times when git-secret is interacting with gnupg, we use the --no-permission-warning option.

We periodically see issues which are related to permissions and I suspect that some of these issues could be spotted earlier by git-secret not using --no-permission-warning

This also relates to possibly setting permissions more carefully and/or the user's umask
joshrabinowitz pushed a commit to joshrabinowitz/git-secret that referenced this issue Mar 31, 2022
set git-secret keys dir to 700 perms, for sobolevn#811
ae7ada2
@joshrabinowitz joshrabinowitz mentioned this issue Mar 31, 2022
Merged
joshrabinowitz added a commit that referenced this issue Apr 1, 2022
@joshrabinowitz
in verbose mode, show some gnupg perm warnings (#812)
db03c63 
* set git-secret keys dir to 700 perms, for #811
* update changelog
* test improvements
* clean up comments
* remove unused code
* update git-secret-init man page
* document change to git-secret-init
joshrabinowitz pushed a commit to joshrabinowitz/git-secret that referenced this issue Apr 10, 2022
for sobolevn#811: allow perm warnings in non-verbose mode
44c6950
@joshrabinowitz joshrabinowitz mentioned this issue Apr 10, 2022
Merged
joshrabinowitz added a commit that referenced this issue Apr 16, 2022
@joshrabinowitz
for #811: allow some perm warnings in non-verbose mode (#825)
084a525
@paslandau paslandau mentioned this issue May 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

in verbose mode, show some gnupg perm warnings joshrabinowitz/git-secret
1 participant
@joshrabinowitz