Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for #811: allow some perm warnings in non-verbose mode #825

Merged

Conversation

joshrabinowitz
Copy link
Collaborator

@joshrabinowitz joshrabinowitz commented Apr 10, 2022

continuing WIP on #811
Continues changes on merged PR #812

Edit: I need to confirm that removing --no-permission-warning can't cause failures in situations that used to work (because of permission issues previously being ignored)
Edit2: above confimed

Copy link
Owner

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks weird:

# run 'add' with bad arg: FINAL OUTPUT: M�MA�AN�NU�UA�AL�L
# run 'add' with bad arg: FINAL OUTPUT:        Run m�ma�an�n g�gi�it�t-�-s�se�ec�cr�re�et�t-�-a�ad�dd�d to see this note.
# run 'add' with bad arg: FINAL OUTPUT: 
# run 'add' with bad arg: FINAL OUTPUT: S�SE�EE�E A�AL�LS�SO�O
# run 'add' with bad arg: FINAL OUTPUT:        git-secret-init(1)               _�h_�t_�t_�p_�s_�:_�/_�/_�g_�i_�t_�-_�s_�e_�c_�r_�e_�t_�._�i_�o_�/_�g_�i_�t_�-_�s_�e_�c_�r_�e_�t_�-_�i_�n_�i_�t,
# run 'add' with bad arg: FINAL OUTPUT:        git-secret-tell(1)               _�h_�t_�t_�p_�s_�:_�/_�/_�g_�i_�t_�-_�s_�e_�c_�r_�e_�t_�._�i_�o_�/_�g_�i_�t_�-_�s_�e_�c_�r_�e_�t_�-_�t_�e_�l_�l,
# run 'add' with bad arg: FINAL OUTPUT:        git-secret-hide(1)               _�h_�t_�t_�p_�s_�:_�/_�/_�g_�i_�t_�-_�s_�e_�c_�r_�e_�t_�._�i_�o_�/_�g_�i_�t_�-_�s_�e_�c_�r_�e_�t_�-_�h_�i_�d_�e,
# run 'add' with bad arg: FINAL OUTPUT:        git-secret-reveal(1) _�h_�t_�t_�p_�s_�:_�/_�/_�g_�i_�t_�-_�s_�e_�c_�r_�e_�t_�._�i_�o_�/_�g_�i_�t_�-_�s_�e_�c_�r_�e_�t_�-_�r_�e_�v_�e_�a_�l

@joshrabinowitz
Copy link
Collaborator Author

joshrabinowitz commented Apr 10, 2022

@sobolevn I think the double character and other weird output from man in the test output is because of terminal escape sequences that man is outputting. The verbose tests have always displayed man pages oddly in github actions; I'm not sure how to remedy it. Maybe we should make a separate issue about that. (Edit: See #826)

@joshrabinowitz joshrabinowitz merged commit 084a525 into sobolevn:master Apr 16, 2022
@joshrabinowitz joshrabinowitz deleted the show-permission-warnings-more branch April 16, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants