Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in verbose mode, show some gnupg perm warnings #812

Merged
merged 22 commits into from
Apr 1, 2022

Conversation

joshrabinowitz
Copy link
Collaborator

@joshrabinowitz joshrabinowitz commented Mar 31, 2022

Closes #811

may relate to #806

@sobolevn : Maybe we should just not use --no-permission-warnings in these cases at all, (even when in non-verbose mode).

@joshrabinowitz joshrabinowitz marked this pull request as ready for review April 1, 2022 00:50
Copy link
Owner

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think that disabling permissions warning can indeed backfire.
This is a good start!

tests/_test_base.bash Show resolved Hide resolved
@joshrabinowitz
Copy link
Collaborator Author

@sobolevn let me know if you're ok with me merging this.

@joshrabinowitz joshrabinowitz merged commit db03c63 into sobolevn:master Apr 1, 2022
@joshrabinowitz joshrabinowitz deleted the gnupg-warnings branch April 1, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reconsider our use of --no-permission-warning because sometimes it is hiding actual permission problems
2 participants