Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

to_upper/1 is not so obvious #2

Closed
sobolevn opened this issue Jul 12, 2017 · 4 comments
Closed

to_upper/1 is not so obvious #2

sobolevn opened this issue Jul 12, 2017 · 4 comments

Comments

@sobolevn
Copy link
Member

to_upper/1 could be misleading. Since upper case is SOME-VALUE.

I guess it should be renamed to to_pascal/1.
@princemaple
Copy link

Maybe don't reinvent the ones that's already in string module? i.e. simply leave out upper, lower, etc.

@sobolevn
Copy link
Member Author

@princemaple thanks for the feedback!

My idea was to rename the existing UpperCase to PascalCase not to create confusion around it's name.

@princemaple
Copy link

Yep, I meant after that, no need to add it back.

@princemaple
Copy link

String module already got upper, lower and capital covered.

sobolevn added a commit that referenced this issue Jul 15, 2017
@sobolevn
Version 0.2.0 release
569c429 
Changes:
- `UpperCase` renamed to `PascalCase`
- `Recase.to_upper/1` renamed to `Recase.to_pascal/1`
- `upper_case_test.exs` renamed to `pascal_case_test.exs`
- Made changes to reflect `Pascal` and `Upper` case issue

Closes #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@princemaple @sobolevn