-
Notifications
You must be signed in to change notification settings - Fork 3
Windows build #1
Comments
Unfortunately I haven't tried building on Windows. That's a missing piece for all of my Conan packages. |
I have made a fork and fixed all issues there. I you find it useful I can
submit PR to your repo.
|
I'd very much appreciate a PR! Thanks for doing that work! |
Done: #2 Are you planning to contribute the package to conan-center? |
I'll certainly contribute to conan-center if this recipe is up to their quality standards. Do you think I should submit? I can't guarantee I'll be a reliable maintainer, unfortunately :( |
I believe the recipe is currently good enough. All major OSes/architectures are supported, CI status is green, not much maintenance is expected. I think you definitely should. Maybe just add Appveyor status like I did in my README.md? I also have a companion recipe for SimpleAmqpClient library, created by the same author as rabbitmq-c. If rabbitmq-c is accepted by conan-center, I will submit my recipe as well. |
Did you ever try to build it with Visual Studio? I have numerous problems there.
The text was updated successfully, but these errors were encountered: