Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

Windows build #1

Open
db4 opened this issue Feb 27, 2018 · 6 comments
Open

Windows build #1

db4 opened this issue Feb 27, 2018 · 6 comments

Comments

@db4
Copy link

db4 commented Feb 27, 2018

Did you ever try to build it with Visual Studio? I have numerous problems there.

@sobotklp
Copy link
Owner

Unfortunately I haven't tried building on Windows. That's a missing piece for all of my Conan packages.

@db4
Copy link
Author

db4 commented Apr 21, 2018 via email

@sobotklp
Copy link
Owner

I'd very much appreciate a PR! Thanks for doing that work!

@db4
Copy link
Author

db4 commented Apr 26, 2018

Done: #2

Are you planning to contribute the package to conan-center?

@sobotklp
Copy link
Owner

I'll certainly contribute to conan-center if this recipe is up to their quality standards. Do you think I should submit? I can't guarantee I'll be a reliable maintainer, unfortunately :(

@db4
Copy link
Author

db4 commented Apr 27, 2018

I believe the recipe is currently good enough. All major OSes/architectures are supported, CI status is green, not much maintenance is expected. I think you definitely should. Maybe just add Appveyor status like I did in my README.md?

I also have a companion recipe for SimpleAmqpClient library, created by the same author as rabbitmq-c. If rabbitmq-c is accepted by conan-center, I will submit my recipe as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants