Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete/manage private places. #51

Closed
jandamm opened this issue Nov 10, 2018 · 5 comments
Closed

Delete/manage private places. #51

jandamm opened this issue Nov 10, 2018 · 5 comments
Assignees
Labels

Comments

@jandamm
Copy link

jandamm commented Nov 10, 2018

I accidentally created a private place and noticed that there seems to be no way to delete a private place.
Would be nice to remove the wrong private place. Now I just had to rename it to "wrong entry".

@sobri909 sobri909 self-assigned this Nov 11, 2018
@sobri909
Copy link
Owner

Hi @jandamm! Arc will delete private places automatically once they are no longer assigned to any visits.

Search for the place name, to find all remaining visits to it, then reassign those to their correct places. Shortly after the private place has no assigned visits remaining, Arc will delete it.

Hope that helps!

Thanks 😄

@jandamm
Copy link
Author

jandamm commented Nov 11, 2018

Thanks for the answer. It hasn't deleted itself by now. I'll just wait a bit longer.
Cheers

@sobri909
Copy link
Owner

If it hasn't been deleted, then either a visit is still assigned to it, or somehow the Place model update failed to happen.

If the former case, then best to check with the search view again, to make sure there's definitely no visits still assigned to it.

If the latter case, you can trigger another Place model update by assigning a visit to that place, then assigning it back to its correct place a few seconds afterwards. (Each time a visit's place is changed, it queues up a model update for both the previously assigned place and the newly assigned place).

@jandamm
Copy link
Author

jandamm commented Nov 12, 2018

Figured it out now.
It was still assigned.

Apparently deleting a visit does not remove the assignment to a private place.

@sobri909
Copy link
Owner

sobri909 commented Nov 12, 2018

Oh, good catch! Yeah that sounds like a bug.

Deleting a visit will cause the visit to be merged into an adjacent item. And will probably not trigger a place ML model update. So that leaves a loophole where an unused place can continue to exist and not get deleted automatically.

I'll file a task for it in Arc's private repo, to make sure I get it fixed over in that repo. (Arc's places ML engine isn't open sourced in LocoKit, due to not wanting to step on Foursquare's toes).

Thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants