Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aplist conversion file throws away the first line #494

Closed
davidelang opened this issue Jul 29, 2022 · 3 comments
Closed

aplist conversion file throws away the first line #494

davidelang opened this issue Jul 29, 2022 · 3 comments

Comments

@davidelang
Copy link
Collaborator

the conversion from aplist.csv to dhcpd.conf.hosts assumes the first line is a header and throws it away.

it should do sanity checking to see if it is a header or data and only ignore it if it's a header

@davidelang davidelang added this to the post 19x milestone Jul 29, 2022
@owendelong
Copy link
Collaborator

Preferred behavior IMHO is to have a comment character or leadin (e.g. # or // or ;) and have the parser strip those in the first pass. Header should be expressed as a comment.

@sarcasticadmin sarcasticadmin removed this from the post 19x milestone Mar 23, 2023
@owendelong
Copy link
Collaborator

Has this been resolved at this point?

@sarcasticadmin
Copy link
Member

I would agree with @owendelong

We can close this as the process for generating the kea.conf has dramatically changed since we were using isc-dhcpd and dhcpd.conf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants