Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Add support to read from url #236

Merged
merged 3 commits into from
Dec 24, 2018
Merged

[MRG] Add support to read from url #236

merged 3 commits into from
Dec 24, 2018

Conversation

vinayak-mehta
Copy link
Contributor

@vinayak-mehta vinayak-mehta commented Dec 24, 2018

Closes #91.

@vinayak-mehta vinayak-mehta changed the title Add support to read from url [MRG] Add support to read from url Dec 24, 2018
@codecov-io
Copy link

codecov-io commented Dec 24, 2018

Codecov Report

Merging #236 into master will decrease coverage by 0.34%.
The diff coverage is 79.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
- Coverage    87.5%   87.15%   -0.35%     
==========================================
  Files          13       13              
  Lines        1416     1456      +40     
  Branches      333      338       +5     
==========================================
+ Hits         1239     1269      +30     
- Misses        121      128       +7     
- Partials       56       59       +3
Impacted Files Coverage Δ
camelot/io.py 100% <ø> (ø) ⬆️
camelot/handlers.py 82.92% <100%> (+0.42%) ⬆️
camelot/utils.py 80.32% <73.68%> (-0.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0198f55...62ed475. Read the comment docs.

@vinayak-mehta vinayak-mehta merged commit 0b85c77 into master Dec 24, 2018
@vinayak-mehta vinayak-mehta deleted the read_url branch December 24, 2018 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants