Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getInitialHeaders and getInitialQuery returns null #29

Closed
tuzzmaniandevil opened this issue Feb 26, 2021 · 5 comments
Closed

getInitialHeaders and getInitialQuery returns null #29

tuzzmaniandevil opened this issue Feb 26, 2021 · 5 comments

Comments

@tuzzmaniandevil
Copy link

When an EngineIoSocket gets created from a web request, The socket gets initialize before the transport runs onRequest. Which means the mInitialQuery and mInitialHeaders are null are they get pulled from the transport which doesn't have those values yet

final EngineIoSocket socket = new EngineIoSocket(lockObject, sid, this, mScheduledExecutor);
final Transport transport = new Polling(lockObject);
socket.init(transport, request);
transport.onRequest(request, response);
@trinopoty
Copy link
Collaborator

This issue has been noted. I'll notify here when I release a version with the fix.

@rabihbeyrouty
Copy link

@trinopoty would you please tell us when this fix will be available .

@trinopoty
Copy link
Collaborator

I had a look at it and this issue doesn't seem to effect any public facing api. Since the socket is already fully initialized when it's reported via the connection event, this issue should be invisible to any code that uses the socket.
Can you provide a minimal example where a code using the socket will receive null values for the query and headers?

@trinopoty
Copy link
Collaborator

Ok. I figured out the issue. Expect to see a new version on maven in a few hours.

@rabihbeyrouty
Copy link

@trinopoty many thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants