Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js XhrDriver doesn't use https module for https URL #254

Closed
snoopaloop opened this issue Jul 31, 2015 · 4 comments
Closed

Node.js XhrDriver doesn't use https module for https URL #254

snoopaloop opened this issue Jul 31, 2015 · 4 comments

Comments

@snoopaloop
Copy link

Hello,

Our sockjs endpoint is fully https, so when connecting with node.js client, the XhrDriver only will use the node http module to do the request, and won't use an https request (making everything fail).

Should I force a different transport that would use https for the /info requests?

Not sure if this is something you want to change, or I could submit a pull request to change this. I didn't find any related issues, so if this is a non-issue, I will just do a local patch because I'm only using this for testing.

Thanks

@brycekahle
Copy link
Contributor

Thanks for the bug report. I will definitely take a look at this. 

@snoopaloop
Copy link
Author

@brycekahle Thanks for the quick reply.

@brycekahle
Copy link
Contributor

I just published 1.0.3 which should fix the issue.

@snoopaloop
Copy link
Author

@brycekahle 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants