Npm install doesn't include dist

[robertdempsey]

Hi,

Great library, using it at work for all of our websocket stuff. I'm in a bit of a bind though, I would like to get rid of the need for bower (even if I have to use it, it doesn't seem to be playing nicely with webpack) but when I install this through npm, the dist directory doesn't come along (I see it's included in .npmignore).

Is this required for the library to work? If I download it manually and put it in my node_modules, everything is hunky dory. Should the dist directory be removed from .npmignore?

Cheers
Rob

[kisdaniel]

Will it be solved?

[andrewfinnell]

I am floored by the exclusion of the dist directory as well.. I just tried to use the npm version of this library only to discover that the AMD compatible files don't get included.. Such a shame. We can fork this repo then install it via the github+npm interface at least.

This is a major issue when using an AMD loader and sockjs via npm. The UMD wrapper code is not in the /lib directory, only in the /dist directory.

[andrewfinnell]

For anyone needing an immediate fix change your package.json to use this instead:

"sockjs-client": "github:parlew/sockjs-client"

It now includes the dist directory.

[brycekahle]

Duplicate of #265

[dbashford]

Excluding dist is a remarkably poor decision.

[dbashford]

@afinnell Any chance you could publish that to NPM as '@parlew/sockjs-client'?

For example:

https://github.com/Mind-Trace/stomp-websocket/blob/master/package.json#L2.

https://www.npmjs.com/package/@mind-trace/stompjs

We aren't able to use GH dependencies via NPM from our build environment.

[dbashford]

@afinnell nevermind, didn't realize that is how private packages work.

I published sockjs-client-web to NPM. In a bit of a crunch. =)