Skip to content

Commit

Permalink
Update faye-websocket and websocket-driver to fix security issue
Browse files Browse the repository at this point in the history
Fix #275
  • Loading branch information
brycekahle committed Jul 31, 2020
1 parent a0f6afb commit 0efb3c9
Show file tree
Hide file tree
Showing 5 changed files with 76 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
node_modules
lib/*.js
*~
package-lock.json
sockjs-protocol
1 change: 1 addition & 0 deletions .npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ Makefile
src
examples
tests
scripts
*~
52 changes: 52 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
}
],
"dependencies": {
"faye-websocket": "^0.10.0",
"faye-websocket": "^0.11.3",
"uuid": "^3.4.0",
"websocket-driver": "0.6.5"
"websocket-driver": "^0.7.4"
},
"devDependencies": {
"coffeescript": "^1.12.7"
Expand Down
20 changes: 20 additions & 0 deletions scripts/test.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
#!/bin/bash

set -e

rm -rf sockjs-protocol
git clone --depth=1 https://github.com/sockjs/sockjs-protocol.git
cd sockjs-protocol
make test_deps pycco_deps
cd ..
node tests/test_server/server.js &
SRVPID=$!
sleep 1

set +e

cd sockjs-protocol
./venv/bin/python sockjs-protocol.py
PASSED=$?
kill $SRVPID
exit $PASSED

0 comments on commit 0efb3c9

Please sign in to comment.