Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OutputSchema.wait_for_finish recurses infinitely due to #52 #59

Closed
sbuss opened this issue Mar 18, 2020 · 2 comments · Fixed by #61
Closed

OutputSchema.wait_for_finish recurses infinitely due to #52 #59

sbuss opened this issue Mar 18, 2020 · 2 comments · Fixed by #61

Comments

@sbuss
Copy link

sbuss commented Mar 18, 2020

#52 introduced an infinite recursion bug in OutputSchema.wait_for_finish.

A call to self.wait_for_finish() was added to OutputSchema.any_failed(), but OutputSchema.wait_for_finish itself has a call to self.any_failed(). This results in infinite recursion.

This change should be reverted: https://github.com/socrata/socrata-py/pull/52/files#diff-f3b3495851a2c0feeab5629242cee2fc
@sbuss sbuss mentioned this issue Mar 18, 2020
Merged
@sbuss sbuss changed the title output_schema.wait_for_finish recurses infinitely due to #52 OutputSchema.wait_for_finish recurses infinitely due to #52 Mar 19, 2020
@sbuss sbuss changed the title OutputSchema.wait_for_finish recurses infinitely due to #52 OutputSchema.wait_for_finish recurses infinitely due to #52 Mar 19, 2020
@sbuss sbuss mentioned this issue Mar 19, 2020
Closed
rozap added a commit that referenced this issue Apr 13, 2020
@rozap
Add default timeout for output schema and source wait_for_finish
607fc16 
* Fixes #59
@rozap rozap mentioned this issue Apr 13, 2020
Merged
@rozap rozap closed this as completed in #61 Apr 13, 2020
@sbuss
Copy link
Author

sbuss commented Apr 13, 2020

I don't believe #61 fixed this issue.

The infinite loop is caused by this flow:

wait_for_finish -> _wait_for_finish -> any_failed -> wait_for_finish

The core problem is that _wait_for_finish calls any_failed before returning, but any_failed calls wait_for_finish. It has nothing to do with the timeout.

@sbuss
Copy link
Author

sbuss commented Apr 21, 2020

Ping again on this. Did you verify that this actually fixed the underlying bug? I don't believe it did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add default timeout for output schema and source wait_for_finish socrata/socrata-py
1 participant
@sbuss