Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample_context does not contain check_name if using a fail expression #1885

Open
BeWe11 opened this issue Jun 5, 2023 · 1 comment
Open

Comments

@BeWe11
Copy link

BeWe11 commented Jun 5, 2023

I'm using a simple custom Sampler to collect failed rows.

When I run a failed rows check with a query, then the sample_context instance in the sampler will have access to the check_name, i.e. sample_context.check_name is being set.

When I run a failed rows check with an expression, the check_name in the sample_context is None.

I did a bit of digging and saw that the UserDefinedFailedRowsCheck explicitely adds the check_name to its Metric, while the UserDefinedFailedRowsExpressionCheck does not. But I'm not sure if this really is the underlying issue.

@jmarien
Copy link
Contributor

jmarien commented Jun 5, 2023

SODA-1754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants