Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unity change ethport's logictype and THROUGHPUT'units as Ki #999

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

tanjiangyu-ghca
Copy link
Contributor

What this PR does / why we need it:
unity change ethport's logictype and THROUGHPUT'units as Ki

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #999 (1d1ab3f) into master (f2765e1) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #999      +/-   ##
==========================================
+ Coverage   70.83%   70.85%   +0.01%     
==========================================
  Files         195      195              
  Lines       23987    23994       +7     
  Branches     3674     3677       +3     
==========================================
+ Hits        16991    17000       +9     
+ Misses       5831     5830       -1     
+ Partials     1165     1164       -1     
Impacted Files Coverage Δ
delfin/drivers/dell_emc/unity/rest_handler.py 44.66% <ø> (ø)
delfin/drivers/dell_emc/unity/consts.py 100.00% <100.00%> (ø)
delfin/drivers/dell_emc/unity/unity.py 68.38% <100.00%> (+0.57%) ⬆️
delfin/drivers/ibm/storwize_svc/ssh_handler.py 74.15% <100.00%> (ø)

@JiuyunZhao
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants