Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable optional executable suffix to indicate SIMD level #219

Merged
merged 2 commits into from
Sep 1, 2020

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Sep 1, 2020

Hello!

Debian uses this patch as we compile hh-suite multiple times on x86-(64), one at each SIMD level.

As an alternative, hh-suite could implement runtime CPU dispatching

@milot-mirdita
Copy link
Member

milot-mirdita commented Sep 1, 2020

Could you add a line similar to set(CHECK_MPI 1 CACHE BOOL "Check MPI availability") etc?

@mr-c
Copy link
Contributor Author

mr-c commented Sep 1, 2020

@milot-mirdita If EXE_SUFFIX isn't defined when calling cmake -DEXE_SUFFIX=ssse3 then it is ignored. Is that good enough?

@milot-mirdita
Copy link
Member

I like doing that since it also contains this short comment that explains what the variable does.

@mr-c
Copy link
Contributor Author

mr-c commented Sep 1, 2020

@milot-mirdita Ah, I understand now. Done!

@milot-mirdita milot-mirdita merged commit 4115c48 into soedinglab:master Sep 1, 2020
@milot-mirdita
Copy link
Member

milot-mirdita commented Sep 1, 2020

I'd recommend to build only SSE2 and AVX2 since we don't use any instructions between those versions and the binaries get quite large.

Thanks a lot!

@mr-c mr-c deleted the exe_suffix branch October 5, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants