forked from apache/kafka
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
MINOR: Remove stray comma from PartitionInfo.toString
Removed the extra ',' character while printing the replicas / in-sync replicas array. Author: Kamal <kamal@nmsworks.co.in> Reviewers: Ismael Juma <ismael@juma.me.uk> Closes apache#2306 from Kamal15/trunk
- Loading branch information
1 parent
581beb3
commit 655c620
Showing
2 changed files
with
44 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
clients/src/test/java/org/apache/kafka/common/PartitionInfoTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
/** | ||
* Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE | ||
* file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file | ||
* to You under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the | ||
* License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on | ||
* an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations under the License. | ||
*/ | ||
package org.apache.kafka.common; | ||
|
||
import org.junit.Assert; | ||
import org.junit.Test; | ||
|
||
public class PartitionInfoTest { | ||
|
||
@Test | ||
public void testToString() { | ||
String topic = "sample"; | ||
int partition = 0; | ||
Node leader = new Node(0, "localhost", 9092); | ||
Node r1 = new Node(1, "localhost", 9093); | ||
Node r2 = new Node(2, "localhost", 9094); | ||
Node[] replicas = new Node[] {leader, r1, r2}; | ||
Node[] inSyncReplicas = new Node[] {leader, r1, r2}; | ||
PartitionInfo partitionInfo = new PartitionInfo(topic, partition, leader, replicas, inSyncReplicas); | ||
|
||
String expected = String.format("Partition(topic = %s, partition = %d, leader = %s, replicas = %s, isr = %s)", | ||
topic, partition, leader.idString(), "[0,1,2]", "[0,1,2]"); | ||
Assert.assertEquals(expected, partitionInfo.toString()); | ||
} | ||
|
||
} |