Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SceneCreator] Pluginizing... #1109

Merged
merged 4 commits into from
Jul 25, 2019
Merged

[SceneCreator] Pluginizing... #1109

merged 4 commits into from
Jul 25, 2019

Conversation

marques-bruno
Copy link
Member

SoftRobots uses SceneCreator for its tests, but as it is built as an out-of-tree project on our CI, libSceneCreator.so can't be found. until this PR is merged at least...

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@marques-bruno marques-bruno added the pr: status to review To notify reviewers to review this pull-request label Jul 23, 2019
@marques-bruno marques-bruno self-assigned this Jul 23, 2019
@hugtalbot
Copy link
Contributor

It seems that the dependency of SofaPhysicsAPI to SceneCreator needs to be fixed.
SofaPhysicsSimulation.cpp:49:10: fatal error: '../plugins/SceneCreator/SceneCreator.h' file not found #include "../plugins/SceneCreator/SceneCreator.h"

@guparan guparan added pr: clean Cleaning the code refactoring Refactor code pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jul 24, 2019
@epernod epernod merged commit 4484e0c into sofa-framework:master Jul 25, 2019
@guparan guparan added this to the v19.12 milestone Jan 14, 2020
@damienmarchal damienmarchal deleted the pluginizing_SceneCreator branch August 25, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guparan guparan guparan approved these changes

@damienmarchal damienmarchal Awaiting requested review from damienmarchal

Assignees

@marques-bruno marques-bruno

Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed refactoring Refactor code
Projects
None yet
Milestone
v19.12
Development

Successfully merging this pull request may close these issues.
4 participants
@marques-bruno @hugtalbot @guparan @epernod