[SofaKernel] Fix FileRepository should not be optional #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…optional. As a consequence boost filesystem and locale are made required
thomas-lemaire
added
the
issue: bug (major)
damienmarchal
changed the title
|
Thanks for this nice complement to #99 ! |
guparan
changed the title
|
[ci-build] |
|
This PR:
|
|
On the dash
http://www.sofa-framework.org/dash/index.php?limit=10&pg=1&user=&branch=pr%2Ffix_filerepository&platform=
I do not see an information to be able to fix any compilation pb, I might not be looking in the right place ? Can you point me the correct dash url ?
thomas
…----- Mail original -----
De: "Damien Marchal" ***@***.***>
À: "sofa-framework/sofa" ***@***.***>
Cc: "thomas-lemaire" ***@***.***>, "Author"
***@***.***>
Envoyé: Jeudi 19 Janvier 2017 10:46:13
Objet: Re: [sofa-framework/sofa] [SofaKernel] Fix FileRepository should not
be optional (#122)
This PR:
* succeed on all compilations setup on the CI.
* does not generates new warnings or test failure.
* does not break existing scenes.
* does not break API compatibility.
* is now 1 week old.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub , or mute the thread .
|
|
@thomas-lemaire You are right, the dashboard and the CI were malfunctionning together resulting in bad reports. But @guparan and @bcarrez spend time to fix it and it should work better now. I restart your build to refresh the status... EDIT3: now the PR build summary is ok. Correctly indicating that the vs2013 failed. In general a failure is not caused by the PR but more often by a bug in the build system...so there is still a need to investgate that. I'm really sorry thomas for the bothering. |
|
@bcarrez Can I merge this one ? The Failure seems related to our broken vs2013. |
guparan
added
pr: fix
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileRepository is used by too many components to be optional.
As a consequence boost filesystem and locale are made required
This commit fixes undefined symbol error occurring at link time when the filesystem or locale boost lib are not installed