-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaKernel] FIX FileRepository on Windows #99
[SofaKernel] FIX FileRepository on Windows #99
Conversation
ADD dependencies to boost::filesystem and boost::locale Fixes #17
I cannot test myself on window but: I let @matthieu-nesme (who made the issue #17) to make the final decision. |
Great! and the fix is impressively concise. |
Not all of them, we could replace |
(edited) Does the job, no test broken, fixes one failing test: green light for me. |
Can I merge it ? |
Nope, I have to search first for any header only improvement. |
So there is no header-only way to use boost::filesystem and boost::locale. |
So we merge it this way ? |
No objections so I vote yes :) |
ADD dependencies to boost::filesystem and boost::locale
Fixes #17