Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CGAL] Fix build problem #351

Merged
merged 4 commits into from
Sep 13, 2017
Merged

Conversation

bcarrez
Copy link
Contributor

@bcarrez bcarrez commented Jul 28, 2017

CGAL plugin has some build issues in some circumstances, this PR aims to fix it:

  • build error if "image" plugin is deactivated
  • BOOST_PARAMETER_MAX_ARITY too low by default (5 by default, where CGAL needs 12 at least)

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@bcarrez bcarrez added issue: bug (major) Critical bug affecting everyone: not working, performances or accuracy degraded pr: fix Fix a bug pr: status wip Development in the pull-request is still in progress labels Jul 28, 2017
@bcarrez
Copy link
Contributor Author

bcarrez commented Jul 28, 2017

There is still a build problem with the "image" plugin. See issue #352 .

@guparan
Copy link
Contributor

guparan commented Aug 23, 2017

[ci-build]

@guparan
Copy link
Contributor

guparan commented Aug 29, 2017

Hi @bcarrez, is this PR still wip?

@damienmarchal damienmarchal changed the title Fix cgal build [CGAL] Fix build problem Sep 7, 2017
@bcarrez bcarrez added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress labels Sep 8, 2017
@bcarrez
Copy link
Contributor Author

bcarrez commented Sep 12, 2017

This PR is not WIP anymore and is ready to review.

@guparan guparan merged commit 4d6a4e6 into sofa-framework:master Sep 13, 2017
@guparan guparan modified the milestones: v17.06, v17.12 Sep 13, 2017
@damienmarchal damienmarchal deleted the fix_CGAL_build branch February 12, 2018 12:53
@guparan guparan added pr: fix Fix a bug and removed pr: fix Fix a bug issue: bug (major) Critical bug affecting everyone: not working, performances or accuracy degraded labels Jun 20, 2019
@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants