-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CGAL] Fix build problem #351
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTICE: implies full SOFA rebuild :-/
bcarrez
added
issue: bug (major)
Critical bug affecting everyone: not working, performances or accuracy degraded
pr: fix
Fix a bug
pr: status wip
Development in the pull-request is still in progress
labels
Jul 28, 2017
There is still a build problem with the "image" plugin. See issue #352 . |
6 tasks
[ci-build] |
Hi @bcarrez, is this PR still wip? |
bcarrez
added
pr: status to review
To notify reviewers to review this pull-request
and removed
pr: status wip
Development in the pull-request is still in progress
labels
Sep 8, 2017
This PR is not WIP anymore and is ready to review. |
guparan
added
pr: fix
Fix a bug
and removed
pr: fix
Fix a bug
issue: bug (major)
Critical bug affecting everyone: not working, performances or accuracy degraded
labels
Jun 20, 2019
hugtalbot
added
pr: status ready
Approved a pull-request, ready to be squashed
and removed
pr: status to review
To notify reviewers to review this pull-request
labels
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CGAL plugin has some build issues in some circumstances, this PR aims to fix it:
This PR:
Reviewers will merge only if all these checks are true.