[MechanicalLoad] Replace doUpdateInternal by callback: ConstantFF

[hugtalbot]

In the spirit of #3900 this PR applies the change on the ConstantForceField.

To be noted:

• return have been added
• the componentState must be added to trigger the callback
• use function isComponentStateValid()
• Create separate addUpdateCallback and created dedicated separate functions
• Remove call to trackData for doUpdateInternal
• Use Accessors (remove beginEdit)

---

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

---

Reviewers will merge this pull-request only if

• it builds with SUCCESS for all platforms on the CI.
• it does not generate new warnings.
• it does not generate new unit test failures.
• it does not generate new scene test failures.
• it does not break API compatibility.
• it is more than 1 week old (or has fast-merge label).

[hugtalbot]

[ci-build][with-all-tests]

[hugtalbot]

just for your 👁️ @damienmarchal

[alxbilger]

Is there a reason why not defining 4 callbacks instead of one with if conditions?

[hugtalbot]

trackInternalData to remove

[hugtalbot]

both comments:

• Is there a reason why not defining 4 callbacks instead of one with if conditions? @alxbilger
• trackInternalData to remove

are implemented in #3936

[hugtalbot]

PR passes now and includes:

• use function isComponentStateValid()
• Create separate addUpdateCallback and created dedicated separate functions
• remove call to trackData for doUpdateInternal
• use Accessors (remove beginEdit)

[hugtalbot]

waiting for your GO @alxbilger @damienmarchal
it would be to be merged along with #4019

[alxbilger]

I still don't like that you keep empty functions with a comment explaining that the code changed. Git is made for that. I would remove reinit and doUpdateInternal. Otherwise, the PR looks ok even though I did not test it.

[hugtalbot]

This PR has to be considered along with #4019