-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mass] Replace doUpdateInternal by callback: UniformMass #3927
base: master
Are you sure you want to change the base?
[Mass] Replace doUpdateInternal by callback: UniformMass #3927
Conversation
only the MeshMatrixMass to go @damienmarchal and .. soon goodbye doUpdateInternal ! |
|
[ci-build][with-all-tests] |
e99cf8c
to
c0cb154
Compare
I like your definition of "soon" 😆 |
Is |
e87252a
to
5b5c29e
Compare
Similar feature is merged for the ConstantForceField in #3924. It adds separate callbacks for each data but a hacky flag allows to avoid data cross-dependency by de-activating all inputs non-set at the initialization. It could be done here as well but a more robust implementation (Data, callback) could be found. Add a unit test to make sure that no data cross-dependency is triggered. Manual test as well. |
it seems from the CI that many tests and scene examples are using UniformMass without any input mass info .. |
[ci-build][with-all-tests] |
[ci-depends-on] detected during build #16. To unlock the merge button, you must
|
2ce47ea
to
14a5ee9
Compare
[ci-depends-on] detected during build #17. To unlock the merge button, you must
|
if(!this->isComponentStateValid()) | ||
msg_error() << "Initialization process is invalid"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review was taken into account last week
14a5ee9
to
a2f9e25
Compare
[ci-depends-on] detected during build #18. To unlock the merge button, you must
|
a2f9e25
to
b20193f
Compare
[ci-depends-on] detected during build #19. All dependencies are merged/closed and all ExternalProject pointers are up-to-date. Congrats! 👍 |
In the spirit of #3900 and following #3924, this PR applies the change on the UniformMass.
To be noted, the
componentState
must be added to trigger the callback (done inaddMDx()
,addMToMatrix
,accFromF
andbuildMassMatrix
)[ci-depends-on https://github.com/SofaDefrost/SoftRobots/pull/272]
[ci-depends-on https://github.com/sofa-framework/Registration/pull/14]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if