FIX no step if condition on denominator is met at first step #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some scenes where presenting strange behavior : no object moving with specific numerical settings, and with some others it was working fine. This was due to a threshold of CG met at first step on denominator value. Now force at least one step.
hugtalbot
added
pr: fix
guparan
added
pr: fast merge
|
Last meeting it was considered to be merged...so here it is. |
damienmarchal
added a commit
to SofaDefrost/sofa
that referenced
this pull request
Dec 27, 2017
… since PR sofa-framework#521 The more I see PR the more I wonder why the algorithm allow 'den' to be zero. Shouldn't this issue a warning saying that the scene is probably broken ?
This was referenced Jan 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some scenes where presenting strange behavior : no object moving
with specific numerical settings, and with some others it was
working fine. This was due to a threshold of CG met at first step
on denominator value. Now force at least one step.
This PR:
Reviewers will merge only if all these checks are true.