Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[All] v18.12 changes #905

Merged
merged 22 commits into from
Feb 5, 2019
Merged

[All] v18.12 changes #905

merged 22 commits into from
Feb 5, 2019

Conversation

guparan
Copy link
Contributor

@guparan guparan commented Jan 25, 2019 •
edited by hugtalbot
Loading

Here are all the changes made for v18.12 release.
Mostly CMake and CPack stuff.

⚠️ Notice the removal of all deprecated components as planned in Changelog.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@guparan
[Changelog] Update for v18.12
3cdd705
@guparan
[CMake] FIX version problem with patch like "00"
54aa166
@guparan
[SofaFramework] EDIT install Zlib on Windows only
735ff5b
@guparan
[CPack] Improve installer
19a76a4
@guparan
[All] REMOVE deprecated components
f5826bf 
Deprecated components to be removed for v18.12:
- [SofaBoundaryCondition] BuoyantForceField
- [SofaBoundaryCondition] VaccumSphereForceField
- [SofaMisc] ParallelCGLinearSolver
- [SofaMiscForceField] ForceMaskOff
- [SofaMiscForceField] LineBendingSprings
- [SofaMiscForceField] WashingMachineForceField
- [SofaMiscMapping] CatmullRomSplineMapping
- [SofaMiscMapping] CenterPointMechanicalMapping
- [SofaMiscMapping] CurveMapping
- [SofaMiscMapping] ExternalInterpolationMapping
- [SofaMiscMapping] ProjectionToLineMapping
- [SofaMiscMapping] ProjectionToPlaneMapping
- [SofaOpenglVisual] OglCylinderModel
- [SofaOpenglVisual] OglGrid
- [SofaOpenglVisual] OglRenderingSRGB
- [SofaOpenglVisual] OglLineAxis
- [SofaOpenglVisual] OglSceneFrame
- [SofaUserInteraction] ArticulatedHierarchyBVHController
- [SofaUserInteraction] ArticulatedHierarchyController
- [SofaUserInteraction] DisabledContact
- [SofaUserInteraction] EdgeSetController
- [SofaUserInteraction] GraspingManager
- [SofaUserInteraction] InterpolationController
- [SofaUserInteraction] MechanicalStateControllerOmni
- [SofaUserInteraction] NodeToggleController
@guparan
[All] REMOVE deprecated methods
21f1ee2 
Deprecated methods to remove for v18.12:
- [SofaHelper] Utils::getPluginDirectory()
@guparan
[CMake] Better Boost message
bdb5f15
@guparan
[CImgPlugin] Disable tiff in binaries
8f2c557 
Issue with jbig dependency
@guparan
[CMake] FIX MacOS install ressource paths
d25061c
@guparan
[CMake] FIX MacOS install ressource paths (2)
f6ed830
@guparan
[SofaHelper] ADD FileRepository::getPathsJoined method
384b042 
Used to improve FileRepository logging in runSofa
@guparan
[All] FIX MacOS bundle
69be46b
@guparan
[runSofa] CLEAN icons and config files
3ee901d
@guparan
[CMake] CLEAN Qt log messages
bf9993f
@guparan
[SofaFramework] ADD GLU to Linux binaries
1e83191
@guparan
[CPack] FIX Windows packaging
cbc6f01
@guparan
[Changelog] Update v18.12
ff11b81
@guparan guparan added enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Jan 25, 2019
@guparan guparan changed the title V18.12 pr [All] v18.12 changes Jan 25, 2019
@damienmarchal
Copy link
Contributor

Ouch...
I think the removal of deprecated component should have been prepared upstream to be sure we are all in-sync and shared agreement with the removal.

Eg of some problems:
https://www.sofa-framework.org/community/forum/topic/problem-when-running-softrobots-python-script-sofa-v18-12-on-ubuntu-16-04/

@guparan
Copy link
Contributor Author

guparan commented Jan 29, 2019 •
edited
Loading

I'm ready to rollback some of the removals. Does it concern all SofaOpenglVisual ones?

@guparan
[SofaOpenglVisual] Rollback removal of Ogl components
06c5295
@guparan
[SofaHelper] Update ComponentChange with removed Components
c608d44
@guparan
[SofaHelper] FIX ComponentChange message set by constructor
e1b55cb 
Explicit map initializations without references or pointers can't benefit from polymorphism.
see sofa::helper::lifecycle::deprecatedComponents initialization.
@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jan 30, 2019
@damienmarchal
Copy link
Contributor

[ci-build][with-scene-tests]

@hugtalbot hugtalbot merged commit 008cd3e into sofa-framework:master Feb 5, 2019
@guparan guparan added the pr: backport done This PR has been backported into the release before its milestone. label Feb 6, 2019
@guparan
Copy link
Contributor Author

guparan commented Feb 6, 2019

Aaaaaaaand we forgot to handle the scenes using deprecated components. Let's fix those 27-30 new scene test errors now 😆

@guparan guparan mentioned this pull request Feb 7, 2019
Merged
6 tasks
@guparan guparan added this to the v18.12 milestone Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement About a possible enhancement pr: backport done This PR has been backported into the release before its milestone. pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v18.12
Development

Successfully merging this pull request may close these issues.
3 participants
@guparan @damienmarchal @hugtalbot