Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaBaseMechanics] Fix barycentric mapping again #924

Merged
merged 2 commits into from
Feb 11, 2019
Merged

[SofaBaseMechanics] Fix barycentric mapping again #924

merged 2 commits into from
Feb 11, 2019

Conversation

EulalieCoevoet
Copy link
Contributor

Fix following discussion on issue #871

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@EulalieCoevoet EulalieCoevoet added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug labels Feb 8, 2019
@damienmarchal
Copy link
Contributor

@guparan , @epernod, @hugtalbot

Could this be processed in fast-merge ?

@epernod
Copy link
Contributor

epernod commented Feb 11, 2019 •
edited
Loading

ok for me, just a shame this was not detected automatically by the tests...
Maybe @damienmarchal or @EulalieCoevoet you could put an issue on that.

@epernod epernod merged commit 384f065 into sofa-framework:master Feb 11, 2019
@damienmarchal damienmarchal deleted the fixBarycentricMappingAgain branch April 24, 2019 23:00
@guparan guparan added this to the v19.06 milestone Jun 20, 2019
@guparan guparan changed the title Fix barycentric mapping again [SofaBaseMechanics] Fix barycentric mapping again Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug
Projects
None yet
Milestone
v19.06
Development

Successfully merging this pull request may close these issues.
4 participants
@EulalieCoevoet @damienmarchal @epernod @guparan