Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaPython2] Add Sofa.hasViewer function #964

Merged
merged 2 commits into from
Mar 15, 2019
Merged

[SofaPython2] Add Sofa.hasViewer function #964

merged 2 commits into from
Mar 15, 2019

Conversation

tgaugry
Copy link
Contributor

@tgaugry tgaugry commented Mar 12, 2019

Add hasViewer() function to Sofa namespace.
This allow checking the graphical context without outputting errors to stderr.

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new unit test failures.
  • does not generate new scene test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@tgaugry tgaugry added enhancement About a possible enhancement pr: status to review To notify reviewers to review this pull-request labels Mar 12, 2019
@guparan guparan added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Mar 13, 2019
@epernod epernod merged commit ed33356 into sofa-framework:master Mar 15, 2019
@tgaugry tgaugry deleted the sofapython-add-hasviewer-fct branch May 22, 2019 08:36
@guparan guparan added this to the v19.06 milestone Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement About a possible enhancement pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v19.06
Development

Successfully merging this pull request may close these issues.
3 participants
@tgaugry @guparan @epernod