add envs for biz starter

[lvjing2]

模块启动时增加 envs 参数，这个在 jdk 多租户里能用上

Summary by CodeRabbit

Summary by CodeRabbit

• New Features

  • Enhanced application launching capabilities to include environment variables alongside arguments.
  • Introduced the ability to handle environment variables in the business installation process.

• Refactor

  • Updated constructors and methods across various components to support the inclusion of environment variables.

[coderabbitai]

Walkthrough

The recent updates introduce enhanced flexibility by incorporating environment variables into the execution and startup processes. This is achieved through modifications across various components, including the addition of new methods and parameters that allow passing and utilizing environment variables alongside traditional arguments. This holistic change aims to offer more dynamic and context-aware execution capabilities.

Changes

Files	Change Summary
.../bootstrap/MainMethodRunner.java .../container/model/BizModel.java .../api/ArkClient.java .../spi/model/Biz.java	Added support for environment variables in method parameters and processing logic.

🐰✨
In the land of code, where the bytes do roam,
A rabbit hopped in, making it home.
With a flick and a hop, it weaved a change,
Environment variables, now within range.
Through fields of Java, it danced with glee,
"Now apps can adapt, as easy as can be!"
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[codecov]

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 78.84%. Comparing base (e74c7ea) to head (3a566fe).
Report is 1 commits behind head on master.

Files	Patch %	Lines
...c/main/java/com/alipay/sofa/ark/api/ArkClient.java	57.14%	3 Missing ⚠️
.../com/alipay/sofa/ark/container/model/BizModel.java	60.00%	2 Missing ⚠️
...om/alipay/sofa/ark/bootstrap/MainMethodRunner.java	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #885      +/-   ##
============================================
+ Coverage     78.76%   78.84%   +0.07%     
  Complexity      831      831              
============================================
  Files           162      162              
  Lines          6767     6777      +10     
  Branches       1006     1007       +1     
============================================
+ Hits           5330     5343      +13     
+ Misses          917      911       -6     
- Partials        520      523       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between e74c7ea and 3a566fe.

Files selected for processing (6)

• sofa-ark-parent/core-impl/archive/src/main/java/com/alipay/sofa/ark/bootstrap/AbstractLauncher.java (2 hunks)
• sofa-ark-parent/core-impl/archive/src/main/java/com/alipay/sofa/ark/bootstrap/MainMethodRunner.java (2 hunks)
• sofa-ark-parent/core-impl/archive/src/test/java/com/alipay/sofa/ark/bootstrap/MainMethodRunnerTest.java (2 hunks)
• sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/model/BizModel.java (2 hunks)
• sofa-ark-parent/core/api/src/main/java/com/alipay/sofa/ark/api/ArkClient.java (4 hunks)
• sofa-ark-parent/core/spi/src/main/java/com/alipay/sofa/ark/spi/model/Biz.java (3 hunks)

Additional comments: 11

sofa-ark-parent/core-impl/archive/src/test/java/com/alipay/sofa/ark/bootstrap/MainMethodRunnerTest.java (1)

• 39-39: The addition of a null parameter in the MainMethodRunner constructor call within the testRunner method aligns with the updated constructor signature to support environment variables. Please ensure the test still effectively validates MainMethodRunner functionality, including the handling of null environment variables.

sofa-ark-parent/core/spi/src/main/java/com/alipay/sofa/ark/spi/model/Biz.java (1)

• 38-44: The addition of the start(String[] args, Map<String, String> envs) method to the Biz interface is a crucial step towards supporting environment variables in business application startups. Please consider enhancing the method's documentation to clarify the expected behavior when envs is null or empty.

sofa-ark-parent/core-impl/archive/src/main/java/com/alipay/sofa/ark/bootstrap/MainMethodRunner.java (3)

• 20-21: The addition of imports for HashMap and Map is necessary for supporting environment variables. Good job on keeping the imports organized.
• 36-46: The introduction of the envs field and its initialization in the constructor are well-implemented. Initializing envs with an empty HashMap if it's null is a good practice to avoid potential NullPointerException.
• 54-54: The comment about adding envs into the tenant of JDK in the run method indicates future work is needed to utilize envs. Please ensure this implementation is completed to fully support environment variables.

sofa-ark-parent/core-impl/archive/src/main/java/com/alipay/sofa/ark/bootstrap/AbstractLauncher.java (2)

• 112-112: The addition of a null parameter in the createMainMethodRunner method's constructor call to MainMethodRunner aligns with the updated constructor to support environment variables. This change is necessary for compatibility.
• 172-172: The addition of a newline in the getMainClass method is a minor formatting change and does not impact functionality.

sofa-ark-parent/core/api/src/main/java/com/alipay/sofa/ark/api/ArkClient.java (3)

• 64-68: The introduction of a static envs field to store environment variables is a significant change. Consider the implications for thread safety and potential side effects across different parts of the application. It might be beneficial to review the usage pattern of these environment variables to ensure they are managed safely.
• 146-152: The addition of getEnvs() and setEnvs(Map<String, String> envs) methods provides a structured way to access and modify environment variables. Ensure that the usage of these methods is consistent and thread-safe across the application.
• 161-174: The modifications to the installBiz() method and the introduction of the doInstallBiz() method to support environment variables are well-implemented. These changes enhance the flexibility of business application installations. Ensure that the handling of environment variables in these methods is thoroughly tested, especially with regards to null or empty values.

sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/model/BizModel.java (1)

• 275-281: The addition of the start(String[] args, Map<String, String> envs) method and the modification of the existing start(String[] args) method to delegate to doStart(String[] args, Map<String, String> envs) are well-implemented. These changes align with the objective of supporting environment variables. Please ensure that null or empty envs values are correctly handled in these methods.

[gaosaroma]

LGTM

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 3a566fe and e7ddf49.

Files selected for processing (1)

• sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/model/BizModel.java (2 hunks)

Files skipped from review as they are similar to previous changes (1)

• sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/model/BizModel.java