Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename typo #893

Merged
merged 5 commits into from
Mar 30, 2024
Merged

rename typo #893

merged 5 commits into from
Mar 30, 2024

Conversation

lvjing2
Copy link
Collaborator

@lvjing2 lvjing2 commented Mar 30, 2024

No description provided.

Copy link
Contributor

coderabbitai bot commented Mar 30, 2024

Warning

Rate Limit Exceeded

@lvjing2 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 57 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 6412923 and 21bd62a.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@sofastack-cla sofastack-cla bot added size/M and removed size/L labels Mar 30, 2024
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.88%. Comparing base (6412923) to head (21bd62a).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #893      +/-   ##
============================================
+ Coverage     78.73%   78.88%   +0.14%     
  Complexity      837      837              
============================================
  Files           164      164              
  Lines          6796     6796              
  Branches       1009     1009              
============================================
+ Hits           5351     5361      +10     
+ Misses          923      912      -11     
- Partials        522      523       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lvjing2 lvjing2 merged commit 6602b96 into master Mar 30, 2024
7 checks passed
@lvjing2 lvjing2 deleted the youji-dev branch March 30, 2024 03:17
lvjing2 added a commit that referenced this pull request Mar 30, 2024
* update logback in ark container

* fix ark container log

* modify biz state record name

* format code

(cherry picked from commit 6602b96)
lvjing2 added a commit that referenced this pull request Mar 31, 2024
* netty support 0.9.x (#843)

* modify test for zip fill to support jdk9+

* fix export import config

* support multi sdk

* format test

* support netty 0.9

(cherry picked from commit 92daff0)

* Update README.md (#846)

(cherry picked from commit 815ea32)

* support multi sdk

(cherry picked from commit 5f7fe98)

* format test

(cherry picked from commit 0f8c409)

* using 0.9 netty

(cherry picked from commit 233f6d7)

* no lib for netty ark plugin

(cherry picked from commit 68c3509)

* set scope = provided for netty

(cherry picked from commit 957f714)

* fix test error "No Ark Container Jar File Found"

(cherry picked from commit e6bfade)

* fix test error (#854)

(cherry picked from commit 917941c)

* fix test error (#855)

* fix test error

* just warn for stop tomcat

* fix test error

(cherry picked from commit c8c384c)

* fix test error (#856)

(cherry picked from commit a77b061)

* update guava version to aviod guava cache pin problem (#853)

* update guava version

* update guava version in container jar

* remove file

---------

Co-authored-by: leo james <leojames.googol@gmail.com>

(cherry picked from commit 51ba5e0)

* update version

* no maven tree when single bundle

* update version

* Update README.md (#869)

(cherry picked from commit 5971b2a)

* add log for file not found

(cherry picked from commit 0d7ca0c)

* simplify artifact id parser

(cherry picked from commit 1969cdb)

* Update sofa-ark-parent/core-impl/archive/src/test/java/com/alipay/sofa/ark/loader/test/jar/JarUtilsTest.java

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
(cherry picked from commit 8134069)

* fix ark plugin  (#877)

* no export apache for web and netty ark plugin

* no lib in ark plugin

(cherry picked from commit af25776)

* parse artifact id with accuracy first (#878)

* no export apache for web and netty ark plugin

* no lib in ark plugin

* parse artifact id with accuracy first

* fix test error

(cherry picked from commit e6ab184)

* add start class in manifest (#883)

* no export apache for web and netty ark plugin

* no lib in ark plugin

* parse artifact id with accuracy first

* fix test error

* add start class in manifest

* fix test

* remove unused field

(cherry picked from commit e74c7ea)

* <feature> add bizFailedEvent (#881)

* <feature> add bizFailedEvent

* format

* add notes

* rename BizFailedEvent to AfterBizFailedEvent

* refactor

---------

Co-authored-by: leo james <leojames.googol@gmail.com>
(cherry picked from commit 1a30e63)

* add envs for biz starter (#885)

* no export apache for web and netty ark plugin

* no lib in ark plugin

* parse artifact id with accuracy first

* fix test error

* add start class in manifest

* fix test

* remove unused field

* add envs for biz start

(cherry picked from commit 12d4da4)

* add envs for install operation (#887)

* add envs for install operation

* fix format

* fix potential resource leaks when install biz

(cherry picked from commit 24bd60d)

* set args as empty array when args = null for startup (#888)

* add envs for install operation

* fix format

* fix potential resource leaks when install biz

* fix null args throw exception for springboot

(cherry picked from commit e4adbcb)

* add bizStateChangeLog (#889)

* add more info for biz.toString()

* format

* format

* update bizinfo

* format

* rename to bizStateRecord

* format

(cherry picked from commit 6659991)

* 1、增加zookeeper注册节点环境变量,新增配置参数com.alipay.sofa.ark.config.env。默认为sofa-ark (#890)

* 1、增加zookeeper注册节点环境变量,新增配置参数com.alipay.sofa.ark.config.env。默认为sofa-ark
2、升级curator版本,重构NodeCache已过时

* 1、增加zookeeper注册节点环境变量,新增配置参数com.alipay.sofa.ark.config.env。默认为sofa-ark
2、升级curator版本,重构NodeCache已过时

---------

Co-authored-by: leo james <leojames.googol@gmail.com>
(cherry picked from commit 5395cbf)

* fix no ark log in ark container (#891)

* update logback in ark container

* fix ark container log

(cherry picked from commit 75fa690)

* update biz state record name (#892)

* update logback in ark container

* fix ark container log

* modify biz state record name

(cherry picked from commit 6412923)

* rename typo (#893)

* update logback in ark container

* fix ark container log

* modify biz state record name

* format code

(cherry picked from commit 6602b96)

* update version

* code format

* remove springboot 1.x 2.x adapter

---------

Co-authored-by: g-stream <ylchen.changshu@gmail.com>
Co-authored-by: Lipeng <44571204+gaosaroma@users.noreply.github.com>
Co-authored-by: hadoop835 <chenjian835@163.com>
lvjing2 added a commit that referenced this pull request Mar 31, 2024
* update logback in ark container

* fix ark container log

* modify biz state record name

* format code

(cherry picked from commit 6602b96)
lvjing2 added a commit that referenced this pull request Apr 1, 2024
* Update README.md (#869)

(cherry picked from commit 5971b2a)

* add log for file not found

(cherry picked from commit 0d7ca0c)

* simplify artifact id parser

(cherry picked from commit 1969cdb)

* Update sofa-ark-parent/core-impl/archive/src/test/java/com/alipay/sofa/ark/loader/test/jar/JarUtilsTest.java

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
(cherry picked from commit 8134069)

* fix ark plugin  (#877)

* no export apache for web and netty ark plugin

* no lib in ark plugin

(cherry picked from commit af25776)

* parse artifact id with accuracy first (#878)

* no export apache for web and netty ark plugin

* no lib in ark plugin

* parse artifact id with accuracy first

* fix test error

(cherry picked from commit e6ab184)

* add start class in manifest (#883)

* no export apache for web and netty ark plugin

* no lib in ark plugin

* parse artifact id with accuracy first

* fix test error

* add start class in manifest

* fix test

* remove unused field

(cherry picked from commit e74c7ea)

* <feature> add bizFailedEvent (#881)

* <feature> add bizFailedEvent

* format

* add notes

* rename BizFailedEvent to AfterBizFailedEvent

* refactor

---------

Co-authored-by: leo james <leojames.googol@gmail.com>
(cherry picked from commit 1a30e63)

* add envs for biz starter (#885)

* no export apache for web and netty ark plugin

* no lib in ark plugin

* parse artifact id with accuracy first

* fix test error

* add start class in manifest

* fix test

* remove unused field

* add envs for biz start

(cherry picked from commit 12d4da4)

* add envs for install operation (#887)

* add envs for install operation

* fix format

* fix potential resource leaks when install biz

(cherry picked from commit 24bd60d)

* set args as empty array when args = null for startup (#888)

* add envs for install operation

* fix format

* fix potential resource leaks when install biz

* fix null args throw exception for springboot

(cherry picked from commit e4adbcb)

* add bizStateChangeLog (#889)

* add more info for biz.toString()

* format

* format

* update bizinfo

* format

* rename to bizStateRecord

* format

(cherry picked from commit 6659991)

* 1、增加zookeeper注册节点环境变量,新增配置参数com.alipay.sofa.ark.config.env。默认为sofa-ark (#890)

* 1、增加zookeeper注册节点环境变量,新增配置参数com.alipay.sofa.ark.config.env。默认为sofa-ark
2、升级curator版本,重构NodeCache已过时

* 1、增加zookeeper注册节点环境变量,新增配置参数com.alipay.sofa.ark.config.env。默认为sofa-ark
2、升级curator版本,重构NodeCache已过时

---------

Co-authored-by: leo james <leojames.googol@gmail.com>
(cherry picked from commit 5395cbf)

* fix no ark log in ark container (#891)

* update logback in ark container

* fix ark container log

(cherry picked from commit 75fa690)

* update biz state record name (#892)

* update logback in ark container

* fix ark container log

* modify biz state record name

(cherry picked from commit 6412923)

* rename typo (#893)

* update logback in ark container

* fix ark container log

* modify biz state record name

* format code

(cherry picked from commit 6602b96)

* code format

* remove springboot 1.x 2.x adapter

* update version

---------

Co-authored-by: Lipeng <44571204+gaosaroma@users.noreply.github.com>
Co-authored-by: hadoop835 <chenjian835@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant