fix no ark log in ark container

[lvjing2]

fix #879

Summary by CodeRabbit

• Chores
  • Updated log.sofa.starter.version to 3.16.3 for enhanced stability and performance.
• Refactor
  • Improved logging configuration management in the application for better clarity and maintenance.
• Bug Fixes
  • Fixed logging issues by updating logback-core and logback-classic versions to 1.2.13.

[coderabbitai]

Walkthrough

The updates encompass enhancements to logging configurations and version upgrades for dependencies in the SOFAArk project. Key changes include the introduction of a mechanism to skip certain configurations, an update to the log.sofa.starter.version to improve logging capabilities, and updates to logback-core and logback-classic versions to enhance logging performance and security. Additionally, the logging system within the ArkContainer has been refined to support more dynamic configuration sources and to ensure that logging behaves as expected across different scenarios.

Changes

File(s)	Summary
pom.xml	Added <skip>true</skip> element within the configuration block.
sofa-ark-bom/pom.xml	Updated log.sofa.starter.version from 3.2.0 to 3.16.3.
.../core-impl/archive/src/main/java/.../DirectoryContainerArchive.java	Updated logback-core and logback-classic versions from 1.2.9 to 1.2.13.
.../core-impl/container/src/main/java/.../ArkContainer.java	Enhanced logging configuration handling and added new methods for logging configuration.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure effective logging in BizModel using ArkLoggerFactory (#879)	✅
Update logging dependencies to newer, more secure versions	✅
Refactor logging system to support dynamic configuration sources	✅
Validate logging behavior across different scenarios and configurations	✅

Poem

In the realm of code, where the rabbits play,
A leap, a hop, in the bright SOFAArk day.
🐾🌟 Logging woes, now far away,
With updates bold, in the fray they stay.
📜🔧 Versions rise, and configs align,
In harmony, the logs now shine.
A tale of change, by the rabbit's design.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[codecov]

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 78.88%. Comparing base (d57f8ad) to head (3e2ae3e).

Files	Patch %	Lines
...va/com/alipay/sofa/ark/container/ArkContainer.java	86.66%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #891      +/-   ##
============================================
+ Coverage     78.74%   78.88%   +0.13%     
- Complexity      834      837       +3     
============================================
  Files           164      164              
  Lines          6799     6796       -3     
  Branches       1007     1009       +2     
============================================
+ Hits           5354     5361       +7     
+ Misses          924      912      -12     
- Partials        521      523       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between d57f8ad and 3e2ae3e.

Files selected for processing (4)

• pom.xml (1 hunks)
• sofa-ark-bom/pom.xml (1 hunks)
• sofa-ark-parent/core-impl/archive/src/main/java/com/alipay/sofa/ark/loader/DirectoryContainerArchive.java (1 hunks)
• sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/ArkContainer.java (3 hunks)

Additional Context Used

Additional comments not posted (6)

sofa-ark-parent/core-impl/archive/src/main/java/com/alipay/sofa/ark/loader/DirectoryContainerArchive.java (1)

45-45: The update of logback-core and logback-classic versions from 1.2.9 to 1.2.13 is noted. Ensure compatibility and thorough testing with the rest of the project to avoid potential issues arising from these updates.

sofa-ark-parent/core-impl/container/src/main/java/com/alipay/sofa/ark/container/ArkContainer.java (3)

59-65: The addition of new constants for logging configuration is a good practice for maintainability and readability. Ensure these constants are used consistently throughout the project.

---

226-247: The refactoring of the reInitializeArkLogger method to handle logging configuration from different sources and set default values is a significant improvement. It enhances the flexibility and maintainability of logging configuration. Ensure thorough testing to validate the behavior with various configurations.

---

249-253: The introduction of the filterAllLogConfig method to filter log configuration keys based on prefixes is a clean and efficient way to manage logging configurations. This method improves the organization and application of logging settings. Good job on this addition.

pom.xml (1)

177-177: Adding <skip>true</skip> to the maven-javadoc-plugin configuration can speed up builds but ensure that this does not impact the generation of Javadocs for release builds where documentation is crucial.

sofa-ark-bom/pom.xml (1)

17-17: Updating the log.sofa.starter.version from 3.2.0 to 3.16.3 is noted. Ensure compatibility with the rest of the project and conduct thorough testing to leverage the newer logging capabilities effectively.