Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix codecov missing #917

Merged
merged 11 commits into from
Apr 29, 2024
Merged

fix codecov missing #917

merged 11 commits into from
Apr 29, 2024

Conversation

lvjing2
Copy link
Collaborator

@lvjing2 lvjing2 commented Apr 29, 2024

Summary by CodeRabbit

  • Chores
    • Updated the version of codecov-action used in workflows to improve code coverage reporting.

@sofastack-cla sofastack-cla bot added bug Something isn't working cla:yes size/XS labels Apr 29, 2024
Copy link
Contributor

coderabbitai bot commented Apr 29, 2024

Walkthrough

This update involves a straightforward version bump of the codecov/codecov-action in GitHub Actions workflows. Both Linux and Windows unit test workflows have been upgraded from version v3.1.4 to v4, enhancing integration with Codecov for improved code coverage analytics.

Changes

Files Change Summary
.github/.../linux_unit_test.yml
.github/.../windows_unit_test.yml
Updated codecov/codecov-action from v3.1.4 to v4

🐇✨
Oh hark! A change does come,
Through lines of code, our tests do hum.
From v3 to v4, we hop with glee,
Better coverage for you and me.
Codecov's charm, now freshly spun. 🌟
🐇✨


Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between bd864a0 and d263efc.
Files selected for processing (2)
  • .github/workflows/linux_unit_test.yml (1 hunks)
  • .github/workflows/windows_unit_test.yml (1 hunks)
Additional comments not posted (2)
.github/workflows/linux_unit_test.yml (1)

28-28: Update to codecov/codecov-action@v4 looks good.

Ensure to verify codecov reports post-update to confirm integration success.

.github/workflows/windows_unit_test.yml (1)

33-33: Update to codecov/codecov-action@v4 looks good.

Ensure to verify codecov reports post-update to confirm integration success.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.50%. Comparing base (1bf4217) to head (d263efc).
Report is 7 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #917      +/-   ##
============================================
- Coverage     78.70%   78.50%   -0.21%     
- Complexity      836      850      +14     
============================================
  Files           164      167       +3     
  Lines          6796     6866      +70     
  Branches       1009     1016       +7     
============================================
+ Hits           5349     5390      +41     
- Misses          923      951      +28     
- Partials        524      525       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lvjing2 lvjing2 merged commit f9cb08d into master Apr 29, 2024
6 of 7 checks passed
@lvjing2 lvjing2 deleted the youji-dev branch April 29, 2024 13:28
lvjing2 added a commit that referenced this pull request May 1, 2024
* try to fix codecov error

(cherry picked from commit f9cb08d)
lvjing2 added a commit that referenced this pull request May 2, 2024
* try to fix codecov error

(cherry picked from commit f9cb08d)
lvjing2 added a commit that referenced this pull request May 2, 2024
* 1. 删除前先标记文件夹已经被回收 2.即使删除失败也不会影响下次模块安装 (#907)

* 1. 删除前先标记文件夹已经被回收,2.对外暴露方法查询文件夹是否被删除

* format file FileUtils.java and FileUtilsTest.java

* fix ut

* fix ut

* Refactor to improve error handling and avoid swallowing exceptions

* fix format check

* fix ut

* refactor fix constant name

* use move file to mark dir is recycled

---------

Co-authored-by: maixiyuan.mxy <maixiyuan.mxy@antgroup.com>
(cherry picked from commit bdea92e)

* Bump org.eclipse.jgit:org.eclipse.jgit in /sofa-ark-bom (#905)

Bumps org.eclipse.jgit:org.eclipse.jgit from 5.9.0.202009080501-r to 5.13.3.202401111512-r.

---
updated-dependencies:
- dependency-name: org.eclipse.jgit:org.eclipse.jgit
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: leo james <leojames.googol@gmail.com>
(cherry picked from commit bae37b8)

* fix "The host does not contain a Context" (#909)

* fix test can't not find tomcat when start web-ark-plugin (#915)

(cherry picked from commit a6a4a3f)

* switch classLoader for web biz to using same bizclassloader for startup and runtime (#913)

* fix classLoader changed for tomcat web handler

* add order

* add switch classLoader in web ark plugin

* format

* enable switch classLoader filter in both base and biz

* fix on trigger event

* add codecov token

* remove unused import

(cherry picked from commit 6303e9c)

* fix codecov missing  (#917)

* try to fix codecov error

(cherry picked from commit f9cb08d)

* support customize outputfile when package ark biz (#919)

support customize outputfile when package ark biz

(cherry picked from commit ffe9332)

* support cutomize outputFile when ark maven (#920)

* support customize outputfile when package ark biz

(cherry picked from commit bbe3deb)

* add endpoint for springboot3

* modify switch classLoader for web in springboot3

* fix test for sprintboot3 endpoint

* update version to 3.1.3

* format test

---------

Co-authored-by: Mak <xiyuanmak@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
lvjing2 added a commit that referenced this pull request May 2, 2024
* 1. 删除前先标记文件夹已经被回收 2.即使删除失败也不会影响下次模块安装 (#907)

* 1. 删除前先标记文件夹已经被回收,2.对外暴露方法查询文件夹是否被删除

* format file FileUtils.java and FileUtilsTest.java

* fix ut

* fix ut

* Refactor to improve error handling and avoid swallowing exceptions

* fix format check

* fix ut

* refactor fix constant name

* use move file to mark dir is recycled

---------

Co-authored-by: maixiyuan.mxy <maixiyuan.mxy@antgroup.com>
(cherry picked from commit bdea92e)

* Bump org.eclipse.jgit:org.eclipse.jgit in /sofa-ark-bom (#905)

Bumps org.eclipse.jgit:org.eclipse.jgit from 5.9.0.202009080501-r to 5.13.3.202401111512-r.

---
updated-dependencies:
- dependency-name: org.eclipse.jgit:org.eclipse.jgit
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: leo james <leojames.googol@gmail.com>
(cherry picked from commit bae37b8)

* fix "The host does not contain a Context" (#909)

* fix test can't not find tomcat when start web-ark-plugin (#915)

(cherry picked from commit a6a4a3f)

* switch classLoader for web biz to using same bizclassloader for startup and runtime (#913)

* fix classLoader changed for tomcat web handler

* add order

* add switch classLoader in web ark plugin

* format

* enable switch classLoader filter in both base and biz

* fix on trigger event

* add codecov token

* remove unused import

(cherry picked from commit 6303e9c)

* fix codecov missing  (#917)

* try to fix codecov error

(cherry picked from commit f9cb08d)

* support customize outputfile when package ark biz (#919)

support customize outputfile when package ark biz

(cherry picked from commit ffe9332)

* support cutomize outputFile when ark maven (#920)

* support customize outputfile when package ark biz

(cherry picked from commit bbe3deb)

* add endpoint for springboot3

* modify switch classLoader for web in springboot3

* udpate version to 3.0.5-SNAPSHOT

* fix test for sprintboot3 endpoint

* format test

---------

Co-authored-by: Mak <xiyuanmak@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla:yes size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant