Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support customize outputfile when package ark biz #919

Merged
merged 13 commits into from
Apr 30, 2024
Merged

support customize outputfile when package ark biz #919

merged 13 commits into from
Apr 30, 2024

Conversation

lvjing2
Copy link
Collaborator

@lvjing2 lvjing2 commented Apr 30, 2024

fix #870

Summary by CodeRabbit

  • Chores

    • Updated the Codecov action to version 4 in GitHub workflows for improved code coverage reporting.
  • Refactor

    • Enhanced handling of outputPath in the build process to better align with user properties.

@sofastack-cla sofastack-cla bot added question Further information is requested cla:yes size/S labels Apr 30, 2024
Copy link
Contributor

coderabbitai bot commented Apr 30, 2024

Walkthrough

This update includes enhancements to the GitHub Actions workflows by upgrading the codecov-action version to improve code coverage reporting. Additionally, it addresses a specific bug in the sofa-ark-maven-plugin related to dependency scanning, ensuring that the output file does not get overwritten due to command-line parameters.

Changes

File Path Change Summary
.github/workflows/.../linux_unit_test.yml Updated codecov/codecov-action from v3.1.4 to v4
.../ark-maven-plugin/.../RepackageMojo.java Modified handling of outputPath and updated import statements

Assessment against linked issues

Objective Addressed Explanation
Fix the dependency scanning issue in sofa-ark-maven-plugin (#870) Changes in outputPath handling suggest an attempt to fix, but specifics of addressing -DoutputFile issue aren't clear from the summary.

🐇✨
A hop, a skip, a code deploy,
Changes big and small, oh boy!
From codecov's span to Java's joy,
Bugs squashed, no coy ploy.
Cheers to devs, with no annoy! 🎉
🥕🐰


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.59%. Comparing base (1bf4217) to head (db3505c).
Report is 8 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #919      +/-   ##
============================================
- Coverage     78.70%   78.59%   -0.12%     
- Complexity      836      850      +14     
============================================
  Files           164      167       +3     
  Lines          6796     6866      +70     
  Branches       1009     1016       +7     
============================================
+ Hits           5349     5396      +47     
- Misses          923      945      +22     
- Partials        524      525       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lvjing2 lvjing2 merged commit ffe9332 into master Apr 30, 2024
6 of 7 checks passed
@lvjing2 lvjing2 deleted the youji-dev branch April 30, 2024 07:29
lvjing2 added a commit that referenced this pull request May 1, 2024
support customize outputfile when package ark biz

(cherry picked from commit ffe9332)
lvjing2 added a commit that referenced this pull request May 2, 2024
support customize outputfile when package ark biz

(cherry picked from commit ffe9332)
lvjing2 added a commit that referenced this pull request May 2, 2024
* 1. 删除前先标记文件夹已经被回收 2.即使删除失败也不会影响下次模块安装 (#907)

* 1. 删除前先标记文件夹已经被回收,2.对外暴露方法查询文件夹是否被删除

* format file FileUtils.java and FileUtilsTest.java

* fix ut

* fix ut

* Refactor to improve error handling and avoid swallowing exceptions

* fix format check

* fix ut

* refactor fix constant name

* use move file to mark dir is recycled

---------

Co-authored-by: maixiyuan.mxy <maixiyuan.mxy@antgroup.com>
(cherry picked from commit bdea92e)

* Bump org.eclipse.jgit:org.eclipse.jgit in /sofa-ark-bom (#905)

Bumps org.eclipse.jgit:org.eclipse.jgit from 5.9.0.202009080501-r to 5.13.3.202401111512-r.

---
updated-dependencies:
- dependency-name: org.eclipse.jgit:org.eclipse.jgit
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: leo james <leojames.googol@gmail.com>
(cherry picked from commit bae37b8)

* fix "The host does not contain a Context" (#909)

* fix test can't not find tomcat when start web-ark-plugin (#915)

(cherry picked from commit a6a4a3f)

* switch classLoader for web biz to using same bizclassloader for startup and runtime (#913)

* fix classLoader changed for tomcat web handler

* add order

* add switch classLoader in web ark plugin

* format

* enable switch classLoader filter in both base and biz

* fix on trigger event

* add codecov token

* remove unused import

(cherry picked from commit 6303e9c)

* fix codecov missing  (#917)

* try to fix codecov error

(cherry picked from commit f9cb08d)

* support customize outputfile when package ark biz (#919)

support customize outputfile when package ark biz

(cherry picked from commit ffe9332)

* support cutomize outputFile when ark maven (#920)

* support customize outputfile when package ark biz

(cherry picked from commit bbe3deb)

* add endpoint for springboot3

* modify switch classLoader for web in springboot3

* fix test for sprintboot3 endpoint

* update version to 3.1.3

* format test

---------

Co-authored-by: Mak <xiyuanmak@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
lvjing2 added a commit that referenced this pull request May 2, 2024
* 1. 删除前先标记文件夹已经被回收 2.即使删除失败也不会影响下次模块安装 (#907)

* 1. 删除前先标记文件夹已经被回收,2.对外暴露方法查询文件夹是否被删除

* format file FileUtils.java and FileUtilsTest.java

* fix ut

* fix ut

* Refactor to improve error handling and avoid swallowing exceptions

* fix format check

* fix ut

* refactor fix constant name

* use move file to mark dir is recycled

---------

Co-authored-by: maixiyuan.mxy <maixiyuan.mxy@antgroup.com>
(cherry picked from commit bdea92e)

* Bump org.eclipse.jgit:org.eclipse.jgit in /sofa-ark-bom (#905)

Bumps org.eclipse.jgit:org.eclipse.jgit from 5.9.0.202009080501-r to 5.13.3.202401111512-r.

---
updated-dependencies:
- dependency-name: org.eclipse.jgit:org.eclipse.jgit
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: leo james <leojames.googol@gmail.com>
(cherry picked from commit bae37b8)

* fix "The host does not contain a Context" (#909)

* fix test can't not find tomcat when start web-ark-plugin (#915)

(cherry picked from commit a6a4a3f)

* switch classLoader for web biz to using same bizclassloader for startup and runtime (#913)

* fix classLoader changed for tomcat web handler

* add order

* add switch classLoader in web ark plugin

* format

* enable switch classLoader filter in both base and biz

* fix on trigger event

* add codecov token

* remove unused import

(cherry picked from commit 6303e9c)

* fix codecov missing  (#917)

* try to fix codecov error

(cherry picked from commit f9cb08d)

* support customize outputfile when package ark biz (#919)

support customize outputfile when package ark biz

(cherry picked from commit ffe9332)

* support cutomize outputFile when ark maven (#920)

* support customize outputfile when package ark biz

(cherry picked from commit bbe3deb)

* add endpoint for springboot3

* modify switch classLoader for web in springboot3

* udpate version to 3.0.5-SNAPSHOT

* fix test for sprintboot3 endpoint

* format test

---------

Co-authored-by: Mak <xiyuanmak@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes question Further information is requested size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

修复 sofa-ark-maven-plugin 打包插件扫描依赖列表报 deps.log.xxx 文件不存在
1 participant