fix "The host does not contain a Context" #909

lvjing2 · 2024-04-22T12:47:18Z

Summary by CodeRabbit

Chores
- Updated the library version to enhance stability and performance.
Bug Fixes
- Improved application behavior when certain features are disabled to prevent unintended interactions.
Refactor
- Optimized web server start-up process for better reliability.

coderabbitai · 2024-04-22T12:47:25Z

Walkthrough

The changes involve updating dependencies, enhancing integration with Spring Boot by excluding specific auto-configurations, and refining error handling in the ArkTomcatWebServer to prevent context loss during exception scenarios. These adjustments aim to stabilize the framework's behavior under specific failure conditions and improve its compatibility with Spring Boot configurations.

Changes

File Path	Change Summary
`pom.xml`	Updated `sofa.ark.version` from `2.2.9-SNAPSHOT` to `2.2.9`.
.../ark-springboot-integration/.../IntrospectBizEndpointOnArkDisabledTest	Added `@EnableAutoConfiguration(exclude = ArkAutoConfiguration.class)` to `EmptyConfiguration`.
.../ark-springboot-starter/src/main/java/.../ArkTomcatWebServer.java	Moved `Context context = findContext();` outside the `try` block to prevent context loss on error.

Assessment against linked issues

Objective (Issue Number)	Addressed	Explanation
Fix "The host does not contain a Context" error (#908)	✅

Poem

🐰 Oh hop and cheer, for changes are here,
🌟 From XML lines to Java's fine gears.
No more lost context in web server's fear,
🛠️ Fixes so slick, they deserve a cheer!
So here's to the devs, with their code so clear,
🎉 May bugs stay away, far and not near!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

* 1. 删除前先标记文件夹已经被回收 2.即使删除失败也不会影响下次模块安装 (#907) * 1. 删除前先标记文件夹已经被回收，2.对外暴露方法查询文件夹是否被删除 * format file FileUtils.java and FileUtilsTest.java * fix ut * fix ut * Refactor to improve error handling and avoid swallowing exceptions * fix format check * fix ut * refactor fix constant name * use move file to mark dir is recycled --------- Co-authored-by: maixiyuan.mxy <maixiyuan.mxy@antgroup.com> (cherry picked from commit bdea92e) * Bump org.eclipse.jgit:org.eclipse.jgit in /sofa-ark-bom (#905) Bumps org.eclipse.jgit:org.eclipse.jgit from 5.9.0.202009080501-r to 5.13.3.202401111512-r. --- updated-dependencies: - dependency-name: org.eclipse.jgit:org.eclipse.jgit dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: leo james <leojames.googol@gmail.com> (cherry picked from commit bae37b8) * fix "The host does not contain a Context" (#909) * fix test can't not find tomcat when start web-ark-plugin (#915) (cherry picked from commit a6a4a3f) * switch classLoader for web biz to using same bizclassloader for startup and runtime (#913) * fix classLoader changed for tomcat web handler * add order * add switch classLoader in web ark plugin * format * enable switch classLoader filter in both base and biz * fix on trigger event * add codecov token * remove unused import (cherry picked from commit 6303e9c) * fix codecov missing (#917) * try to fix codecov error (cherry picked from commit f9cb08d) * support customize outputfile when package ark biz (#919) support customize outputfile when package ark biz (cherry picked from commit ffe9332) * support cutomize outputFile when ark maven (#920) * support customize outputfile when package ark biz (cherry picked from commit bbe3deb) * add endpoint for springboot3 * modify switch classLoader for web in springboot3 * fix test for sprintboot3 endpoint * update version to 3.1.3 * format test --------- Co-authored-by: Mak <xiyuanmak@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 1. 删除前先标记文件夹已经被回收 2.即使删除失败也不会影响下次模块安装 (#907) * 1. 删除前先标记文件夹已经被回收，2.对外暴露方法查询文件夹是否被删除 * format file FileUtils.java and FileUtilsTest.java * fix ut * fix ut * Refactor to improve error handling and avoid swallowing exceptions * fix format check * fix ut * refactor fix constant name * use move file to mark dir is recycled --------- Co-authored-by: maixiyuan.mxy <maixiyuan.mxy@antgroup.com> (cherry picked from commit bdea92e) * Bump org.eclipse.jgit:org.eclipse.jgit in /sofa-ark-bom (#905) Bumps org.eclipse.jgit:org.eclipse.jgit from 5.9.0.202009080501-r to 5.13.3.202401111512-r. --- updated-dependencies: - dependency-name: org.eclipse.jgit:org.eclipse.jgit dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: leo james <leojames.googol@gmail.com> (cherry picked from commit bae37b8) * fix "The host does not contain a Context" (#909) * fix test can't not find tomcat when start web-ark-plugin (#915) (cherry picked from commit a6a4a3f) * switch classLoader for web biz to using same bizclassloader for startup and runtime (#913) * fix classLoader changed for tomcat web handler * add order * add switch classLoader in web ark plugin * format * enable switch classLoader filter in both base and biz * fix on trigger event * add codecov token * remove unused import (cherry picked from commit 6303e9c) * fix codecov missing (#917) * try to fix codecov error (cherry picked from commit f9cb08d) * support customize outputfile when package ark biz (#919) support customize outputfile when package ark biz (cherry picked from commit ffe9332) * support cutomize outputFile when ark maven (#920) * support customize outputfile when package ark biz (cherry picked from commit bbe3deb) * add endpoint for springboot3 * modify switch classLoader for web in springboot3 * udpate version to 3.0.5-SNAPSHOT * fix test for sprintboot3 endpoint * format test --------- Co-authored-by: Mak <xiyuanmak@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

lvjing2 added 2 commits April 7, 2024 19:18

udpate to 2.2.9

f2ef098

fix #908: "The host does not contain a Context" error

2cc504a

sofastack-cla bot added bug Something isn't working cla:yes size/XS labels Apr 22, 2024

lvjing2 added 2 commits April 22, 2024 20:47

Merge branch 'master' into youji-dev

93bfc65

Merge branch 'master' into youji-dev

1cbd140

lvjing2 merged commit 4364181 into master Apr 22, 2024
3 of 5 checks passed

lvjing2 deleted the youji-dev branch April 22, 2024 12:54

lvjing2 added a commit that referenced this pull request May 1, 2024

fix "The host does not contain a Context" (#909)

ae2a510

lvjing2 added a commit that referenced this pull request May 2, 2024

fix "The host does not contain a Context" (#909)

92d0fbb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix "The host does not contain a Context" #909

fix "The host does not contain a Context" #909

lvjing2 commented Apr 22, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 22, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

fix "The host does not contain a Context" #909

fix "The host does not contain a Context" #909

Conversation

lvjing2 commented Apr 22, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Apr 22, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

lvjing2 commented Apr 22, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 22, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)