-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix "The host does not contain a Context" #909
Conversation
WalkthroughThe changes involve updating dependencies, enhancing integration with Spring Boot by excluding specific auto-configurations, and refining error handling in the ArkTomcatWebServer to prevent context loss during exception scenarios. These adjustments aim to stabilize the framework's behavior under specific failure conditions and improve its compatibility with Spring Boot configurations. Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
* 1. 删除前先标记文件夹已经被回收 2.即使删除失败也不会影响下次模块安装 (#907) * 1. 删除前先标记文件夹已经被回收,2.对外暴露方法查询文件夹是否被删除 * format file FileUtils.java and FileUtilsTest.java * fix ut * fix ut * Refactor to improve error handling and avoid swallowing exceptions * fix format check * fix ut * refactor fix constant name * use move file to mark dir is recycled --------- Co-authored-by: maixiyuan.mxy <maixiyuan.mxy@antgroup.com> (cherry picked from commit bdea92e) * Bump org.eclipse.jgit:org.eclipse.jgit in /sofa-ark-bom (#905) Bumps org.eclipse.jgit:org.eclipse.jgit from 5.9.0.202009080501-r to 5.13.3.202401111512-r. --- updated-dependencies: - dependency-name: org.eclipse.jgit:org.eclipse.jgit dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: leo james <leojames.googol@gmail.com> (cherry picked from commit bae37b8) * fix "The host does not contain a Context" (#909) * fix test can't not find tomcat when start web-ark-plugin (#915) (cherry picked from commit a6a4a3f) * switch classLoader for web biz to using same bizclassloader for startup and runtime (#913) * fix classLoader changed for tomcat web handler * add order * add switch classLoader in web ark plugin * format * enable switch classLoader filter in both base and biz * fix on trigger event * add codecov token * remove unused import (cherry picked from commit 6303e9c) * fix codecov missing (#917) * try to fix codecov error (cherry picked from commit f9cb08d) * support customize outputfile when package ark biz (#919) support customize outputfile when package ark biz (cherry picked from commit ffe9332) * support cutomize outputFile when ark maven (#920) * support customize outputfile when package ark biz (cherry picked from commit bbe3deb) * add endpoint for springboot3 * modify switch classLoader for web in springboot3 * fix test for sprintboot3 endpoint * update version to 3.1.3 * format test --------- Co-authored-by: Mak <xiyuanmak@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* 1. 删除前先标记文件夹已经被回收 2.即使删除失败也不会影响下次模块安装 (#907) * 1. 删除前先标记文件夹已经被回收,2.对外暴露方法查询文件夹是否被删除 * format file FileUtils.java and FileUtilsTest.java * fix ut * fix ut * Refactor to improve error handling and avoid swallowing exceptions * fix format check * fix ut * refactor fix constant name * use move file to mark dir is recycled --------- Co-authored-by: maixiyuan.mxy <maixiyuan.mxy@antgroup.com> (cherry picked from commit bdea92e) * Bump org.eclipse.jgit:org.eclipse.jgit in /sofa-ark-bom (#905) Bumps org.eclipse.jgit:org.eclipse.jgit from 5.9.0.202009080501-r to 5.13.3.202401111512-r. --- updated-dependencies: - dependency-name: org.eclipse.jgit:org.eclipse.jgit dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: leo james <leojames.googol@gmail.com> (cherry picked from commit bae37b8) * fix "The host does not contain a Context" (#909) * fix test can't not find tomcat when start web-ark-plugin (#915) (cherry picked from commit a6a4a3f) * switch classLoader for web biz to using same bizclassloader for startup and runtime (#913) * fix classLoader changed for tomcat web handler * add order * add switch classLoader in web ark plugin * format * enable switch classLoader filter in both base and biz * fix on trigger event * add codecov token * remove unused import (cherry picked from commit 6303e9c) * fix codecov missing (#917) * try to fix codecov error (cherry picked from commit f9cb08d) * support customize outputfile when package ark biz (#919) support customize outputfile when package ark biz (cherry picked from commit ffe9332) * support cutomize outputFile when ark maven (#920) * support customize outputfile when package ark biz (cherry picked from commit bbe3deb) * add endpoint for springboot3 * modify switch classLoader for web in springboot3 * udpate version to 3.0.5-SNAPSHOT * fix test for sprintboot3 endpoint * format test --------- Co-authored-by: Mak <xiyuanmak@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
fix #908
Summary by CodeRabbit
Chores
Bug Fixes
Refactor